Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audioplayer CSS is breaking NC13 files action menu #264

Closed
juliushaertl opened this issue Jan 3, 2018 · 3 comments
Closed

Audioplayer CSS is breaking NC13 files action menu #264

juliushaertl opened this issue Jan 3, 2018 · 3 comments
Assignees
Labels
Milestone

Comments

@juliushaertl
Copy link
Contributor

The following CSS rules from style.css is breaking the position of the file action menu with Nextcloud 13:

.fileActionsMenu {
    margin-top: 30px;
    margin-right: 5px;
    padding-bottom: 15px;
    top: unset;
}

bildschirmfoto vom 2018-01-03 16-44-44

@ghost ghost assigned Rello Jan 3, 2018
@ghost ghost added bug design labels Jan 3, 2018
@ghost
Copy link

ghost commented Jan 3, 2018

@juliushaertl Thanks for reporting this issue! This also affects Nextcloud 12.

@Rello
Copy link
Owner

Rello commented Jan 3, 2018

interesting that it was not recognised yet.

the issue is, that the AP css is loaded in the files-app without being required at all.
will fix
https://github.com/Rello/audioplayer/blob/master/appinfo/app.php#L23

@juliushaertl do you have an idea on how to distinguish between files app and share-screen in a proper way to inject the files more focused?

@juliushaertl
Copy link
Contributor Author

@Rello files and files_sharing have events for additional scripts that can also be used for styles:

See https://github.com/nextcloud/richdocuments/blob/master/appinfo/app.php#L37-L51 for example.

@Rello Rello added this to the 2.2.3 milestone Jan 3, 2018
@ghost ghost added the testing label Jan 3, 2018
ghost pushed a commit that referenced this issue Jan 3, 2018
@ghost ghost removed the testing label Jan 16, 2018
@ghost ghost closed this as completed Jan 16, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants