Adding ability to mock extern "C" functions #304
Merged
Wilfred merged 2 commits intoremacs:masterfrom Sep 16, 2017
Merged
Conversation
…yer. This is done via a mocking library using proc macros. Adding a basic test as an example.
Member
|
I don't feel confident enough to review PRs. Hopefully somebody with more experience has the time to take a look at it soon. |
Collaborator
Author
|
No problem @brotzeit . As a call out, this crate should only affect the app when running in test configuration. It should have zero affect on symbols/variables/etc when running cargo build or cargo build --release |
Wilfred
approved these changes
Sep 16, 2017
Collaborator
Wilfred
left a comment
Wilfred
left a comment
There was a problem hiding this comment.
LGTM :)
I'm sure we'll polish this as we expand our test coverage, but it is absolutely brilliant to have everything we need to write unit tests of our low-level code :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding ability to mock extern "C" functions defined by the emacs C layer. This is done via a mocking library using proc macros. Adding a basic test as an example.
This is the solution that was discussed in #299 It is using a library that I maintain, which can be found here: https://github.com/DavidDeSimone/mock_derive