implemented process-name #341
Merged
Conversation
| @@ -736,6 +736,8 @@ pub struct Lisp_Char_Table { | |||
|
|
|||
| #[repr(C)] | |||
| pub struct Lisp_Process { | |||
| pub header: Lisp_Vectorlike_Header, | |||
birkenfeld
Oct 4, 2017
Collaborator
So... nobody was using the members before?
So... nobody was using the members before?
Yarikx
Oct 4, 2017
Author
Collaborator
Apparently. I was getting tty_name instead of name there.
Apparently. I was getting tty_name instead of name there.
rust_src/src/process.rs
Outdated
| /// Return t if OBJECT is a process. | ||
| #[lisp_fn] | ||
| pub fn processp(object: LispObject) -> LispObject { | ||
| LispObject::from_bool(object.is_process()) | ||
| return LispObject::from_bool(object.is_process()); |
birkenfeld
Oct 4, 2017
Collaborator
unnecessary (and unidiomatic) change, please revert
unnecessary (and unidiomatic) change, please revert
Yarikx
Oct 4, 2017
Author
Collaborator
Added it because of failing build on Travis. I don't like that return either.
Added it because of failing build on Travis. I don't like that return either.
rust_src/src/process.rs
Outdated
| impl LispProcessRef { | ||
| #[inline] | ||
| fn name(&self) -> LispObject { | ||
| return LispObject::from_raw(self.name); |
birkenfeld
Oct 4, 2017
Collaborator
return can be removed here too
return can be removed here too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Closes #331