Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve matching conditions of a keyboard definition #587

Open
yoichiro opened this issue Aug 27, 2021 · 2 comments · Fixed by #600
Open

Improve matching conditions of a keyboard definition #587

yoichiro opened this issue Aug 27, 2021 · 2 comments · Fixed by #600
Assignees
Labels
bug Something isn't working

Comments

@yoichiro
Copy link
Collaborator

Currently, the matching conditions of a keyboard definition are the following:

(1) Search keyboard definitions from the Firestore database with a combination of "Vendor ID" and "Product ID".
(2) If the number of the result of (1) is a single, use the keyboard definition as the result of the matching.
(3) If the number of the result of (1) is multiple, furthermore search a keyboard definition with "PRODUCT" string from the result. If exists, use the keyboard definition as the result of the matching.

When importing a JSON file from a user's local environment, and there is same combination of vendor ID and product ID in the database, the current version of Remap has an issue to return different keyboard definition because of without doing matching the PRODUCT string.

We should improve the 2nd condition to add a PRODUCT string as a matching rule.

@yoichiro yoichiro self-assigned this Aug 27, 2021
@yoichiro yoichiro added the bug Something isn't working label Aug 27, 2021
@yoichiro
Copy link
Collaborator Author

Accurately, the endsWith is used for the matching of PRODUCT strings.

@yoichiro
Copy link
Collaborator Author

Due to #600, Corne keyboard cannot be detected with VID and PID combination only. This is a big problem. Basically, all keyboards should be able to be detected with VID and PID only. According to this policy, the #600 should be reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant