New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for React 16.0.0 #43

Closed
brandontrowe opened this Issue Sep 27, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@brandontrowe

brandontrowe commented Sep 27, 2017

./~/html-react-parser/lib/property-config.js Module not found: Can't resolve 'react-dom/lib/SVGDOMPropertyConfig' in 'C:\Users\roweb\Documents\workspace\poc-digital-job-aids-ui\node_modules\html-react-parser\lib'

It looks like some of the SVGDOMPropertyConfig files are no longer available to import with the new version of react. Their suggestion is to copy and paste the code...

See: facebook/react#10391

I don't think we plan to expose them directly. Their format sometimes changes and we want to be able to make more under the hood changes to them in the future.

While it is a bit annoying I encourage you to just copy and paste them (and update if you notice changes on our side).

@remarkablemark

This comment has been minimized.

Show comment
Hide comment
@remarkablemark

remarkablemark Sep 28, 2017

Owner

Thanks for bringing this to my attention @brandontrowe

I'll copy the DOM property configs over and make a release either today or tomorrow.

Owner

remarkablemark commented Sep 28, 2017

Thanks for bringing this to my attention @brandontrowe

I'll copy the DOM property configs over and make a release either today or tomorrow.

@remarkablemark remarkablemark self-assigned this Sep 28, 2017

remarkablemark added a commit that referenced this issue Oct 1, 2017

feat(property-config): get property configs from `react-dom-core`
Because `react-dom` v16 no longer exposes `lib`, `react-dom-core`
is used. See issue: facebook/react#10391

Resolves #43

@remarkablemark remarkablemark closed this in #44 Oct 1, 2017

@remarkablemark

This comment has been minimized.

Show comment
Hide comment
@remarkablemark

remarkablemark Oct 1, 2017

Owner

@brandontrowe html-react-parser@0.4.0 should resolve the issue now:

# npm
npm install html-react-parser@0.4.0 --save

# yarn
yarn upgrade html-react-parser@0.4.0

It includes a new dependency react-dom-core which copies and exposes modules in lib from react-dom@15.6.2.

Let me know if you encounter any issues.

Owner

remarkablemark commented Oct 1, 2017

@brandontrowe html-react-parser@0.4.0 should resolve the issue now:

# npm
npm install html-react-parser@0.4.0 --save

# yarn
yarn upgrade html-react-parser@0.4.0

It includes a new dependency react-dom-core which copies and exposes modules in lib from react-dom@15.6.2.

Let me know if you encounter any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment