Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Add TypeScript definitions for domToReact #100
What is the motivation for this pull request?
The docs use
Hi @remarkablemark. I have been doing some testing with this today. It seems that the
The possible solutions:
What are your thoughts on these options? Personally I think option 1 is better, as it doesn't change the current API, and allows for other files to be exposed in TS even if they aren't necessarily part of the public facing API.
An example of what option 1 would look like: remarkablemark/html-dom-parser#12.
@AndrewLeedham Thanks for looking into this and coming up with both approaches.
I'm fine with either approach and I agree that the first is cleaner. But I also do think that it may be useful to expose
Given that, would you still like me to go ahead with merging remarkablemark/html-dom-parser#12?