Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: replace `webpack` with `rollup` in order to optimize bundle #118

Merged
merged 3 commits into from Jul 9, 2019

Conversation

Projects
None yet
2 participants
@remarkablemark
Copy link
Owner

commented Jul 9, 2019

File Webpack Rollup
html-react-parser.js 53K 43K
html-react-parser.min.js 17K 15K
html-react-parser.min.js.map 70K 64K

remarkablemark added some commits Jul 9, 2019

build: replace `webpack` with `rollup` in order to optimize bundle
Save devDependencies:

* rollup@1.16.2
* rollup-plugin-commonjs@10.0.0
* rollup-plugin-node-resolve@5.0.4
* rollup-plugin-uglify@6.0.2

Remove `webpack.config.js` and add `rollup.config.js`

Update npm scripts `build:min` and `build:unmin`
build(index): fix rollup error of mixing named and default exports
```
(!) Mixing named and default exports
Consumers of your bundle will have to use bundle['default'] to access the default export, which may not be what you want. Use `output.exports: 'named'` to disable this warning
```

This fixes the UMD bundle (in `dist`) as the library can only be
accessed via the default export.
@coveralls

This comment has been minimized.

Copy link

commented Jul 9, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 00a4aad on build/rollup into 474c8cd on master.

@remarkablemark remarkablemark merged commit d1c3ad8 into master Jul 9, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

@remarkablemark remarkablemark deleted the build/rollup branch Jul 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.