New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `react-dom-core` to support react-dom@16 #44

Merged
merged 5 commits into from Oct 1, 2017

Conversation

Projects
None yet
2 participants
@remarkablemark
Owner

remarkablemark commented Oct 1, 2017

Resolves #43

Because react-dom v16 no longer exposes lib (see issue), which includes the DOM property configs, react-dom-core is used as an alternative.

remarkablemark added some commits Oct 1, 2017

feat(property-config): get property configs from `react-dom-core`
Because `react-dom` v16 no longer exposes `lib`, `react-dom-core`
is used. See issue: facebook/react#10391

Resolves #43
chore(package): upgrade `react` and `react-dom` to 16
And update test fixtures as `ReactDOMServer.renderToStaticMarkup()`
has changed in its output compared to the previous major version.
chore(readme): tidy README instructions and examples
Remove installation instructions for `react` <15.4 because
`html-react-parser` now depends on `react-dom-core`.

Update cdn installation with `react` 16.

Add `react-dom-core` to 'Special Thanks'.

@remarkablemark remarkablemark self-assigned this Oct 1, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 1, 2017

Coverage Status

Coverage remained the same at 99.237% when pulling d760c47 on react-16 into bb7e688 on master.

coveralls commented Oct 1, 2017

Coverage Status

Coverage remained the same at 99.237% when pulling d760c47 on react-16 into bb7e688 on master.

@remarkablemark remarkablemark merged commit aed167d into master Oct 1, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 99.237%
Details

@remarkablemark remarkablemark deleted the react-16 branch Oct 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment