From 0d162c51268811ccc41e51bac296908e521d5548 Mon Sep 17 00:00:00 2001
From: Titus Wormer <tituswormer@gmail.com>
Date: Thu, 9 Aug 2018 15:24:32 -0400
Subject: [PATCH] Refactor code-style

---
 README.md    |  35 +++++++-----
 index.js     | 138 +++++++++++++++++++++++---------------------
 package.json |  27 ++++++++-
 test/test.js | 158 +++++++++++++++++++++++++++------------------------
 4 files changed, 203 insertions(+), 155 deletions(-)

diff --git a/README.md b/README.md
index afb48b3..e8a4148 100644
--- a/README.md
+++ b/README.md
@@ -2,23 +2,19 @@
 
 # remark-defsplit
 
-[![Build Status][travis-badge]][travis] [![Dependency Status][david-badge]][david]
+[![Build Status][travis-badge]][travis]
+[![Dependency Status][david-badge]][david]
 
 Extract inline link/image destinations as separate definitions.
 
-[travis]: https://travis-ci.org/eush77/remark-defsplit
-[travis-badge]: https://travis-ci.org/eush77/remark-defsplit.svg
-[david]: https://david-dm.org/eush77/remark-defsplit
-[david-badge]: https://david-dm.org/eush77/remark-defsplit.png
-
 ## Example
 
-```
+```bash
 $ travisjs badge
 [![Build Status](https://travis-ci.org/eush77/remark-defsplit.svg?branch=master)](https://travis-ci.org/eush77/remark-defsplit)
 ```
 
-```
+```bash
 $ travisjs badge | remark --use remark-defsplit='id:["travis-badge","travis"]'
 [![Build Status][travis-badge]][travis]
 
@@ -31,13 +27,13 @@ $ travisjs badge | remark --use remark-defsplit='id:["travis-badge","travis"]'
 
 With [remark](https://github.com/wooorm/remark) do:
 
-```
+```javascript
 remark().use(remarkDefsplit, [options]).processSync(src)
 ```
 
 #### options.id
 
-Type: `String | [String]` <br>
+Type: `String | [String]`.
 Default: `[]`
 
 Array of identifiers to use for new definitions in place of auto-generated ones.
@@ -46,7 +42,7 @@ Array of identifiers to use for new definitions in place of auto-generated ones.
 
 With [remark](https://github.com/wooorm/remark) do:
 
-```
+```sh
 remark --use remark-defsplit[=options] </path/to/src
 ```
 
@@ -59,15 +55,24 @@ remark --use remark-defsplit[=options] </path/to/src
     — Reverse, thus rewriting references and definitions into normal links
       and images
 
-[remark-reference-links]: https://github.com/wooorm/remark-reference-links
-[remark-inline-links]: https://github.com/wooorm/remark-inline-links
-
 ## Install
 
-```
+```sh
 npm install remark-defsplit
 ```
 
 ## License
 
 MIT
+
+[travis]: https://travis-ci.org/eush77/remark-defsplit
+
+[travis-badge]: https://travis-ci.org/eush77/remark-defsplit.svg
+
+[david]: https://david-dm.org/eush77/remark-defsplit
+
+[david-badge]: https://david-dm.org/eush77/remark-defsplit.png
+
+[remark-reference-links]: https://github.com/wooorm/remark-reference-links
+
+[remark-inline-links]: https://github.com/wooorm/remark-inline-links
diff --git a/index.js b/index.js
index 358eb82..8a2d3b4 100644
--- a/index.js
+++ b/index.js
@@ -1,94 +1,102 @@
-'use strict';
+'use strict'
 
-var Index = require('unist-util-index');
-
-var url = require('url'),
-    path = require('path');
+var url = require('url')
+var path = require('path')
+var Index = require('unist-util-index')
 
 var concat = [].concat
+var push = [].push
+
+module.exports = defsplit
+
+function defsplit(opts) {
+  var id = (opts || {}).id || []
+  var ids = (typeof id === 'object' && 'length' in id ? id : [id]).map(String)
+
+  return transform
+
+  function transform(ast) {
+    var definitionsById = new Index(ast, 'definition', 'identifier')
+    var definitionsByUrl = new Index(ast, 'definition', 'url')
+    var definitions = []
+    var hosts = Object.create(null)
+
+    postorder(ast)
+
+    push.apply(ast.children, definitions)
+
+    function postorder(node) {
+      var nodes
 
-module.exports = function (opts) {
-  opts = opts || {};
-  opts.id = (opts.id
-             ? (Array.isArray(opts.id)
-                ? opts.id.map(String)
-                : [String(opts.id)])
-             : []);
-
-  return function (ast) {
-    var definitionsById = Index(ast, 'definition', function (definition) {
-      return definition.identifier.toLowerCase();
-    });
-    var definitionsByLink = Index(ast, 'definition', 'url');
-    var newDefinitions = [];
-    var hostCount = Object.create(null);
-
-    (function postorder (node) {
       if (node.children) {
-        node.children = concat.apply([], node.children.map(postorder));
+        node.children = concat.apply([], node.children.map(postorder))
       }
-      return forNode.apply(null, arguments) || node;
-    }(ast));
-
-    [].push.apply(ast.children, newDefinitions);
 
-    function forNode (node) {
-      if (node.type == 'definition' || node.type == 'heading') {
-        var nodes = newDefinitions.concat(node);
-        newDefinitions.length = 0;
-        return nodes;
+      if (node.type === 'definition' || node.type === 'heading') {
+        nodes = definitions.concat(node)
+        definitions = []
+        return nodes
       }
 
-      if (node.type !== 'link' && node.type !== 'image') return;
+      if (node.type === 'link' || node.type === 'image') {
+        node.type += 'Reference'
+        node.referenceType = 'full'
+        node.identifier = identifier(node.url, node.title)
 
-      node.type += 'Reference';
-      node.referenceType = 'full';
-      node.identifier = identifier(node.url, node.title);
+        delete node.url
+        delete node.title
+      }
 
-      delete node.url;
-      delete node.title;
+      return node
     }
 
-    function identifier (link, title) {
-      var identifier;
-
-      var found = definitionsByLink.get(link).some(function (def) {
-        if (def.title == title) {
-          identifier = def.identifier;
-          return true;
-        }
-      });
+    function identifier(link, title) {
+      var identifier = null
+      var found = definitionsByUrl.get(link).some(some)
+      var host
+      var definition
 
       if (found) {
-        return identifier;
+        return identifier
       }
 
-      if (!(identifier = opts.id.shift())) {
-        var host = urlHost(link);
-        hostCount[host] |= 0;
+      identifier = ids.shift()
+
+      if (!identifier) {
+        host = urlHost(link)
+        hosts[host] |= 0
+
         do {
-          identifier = (host ? host + '-' : '') + ++hostCount[host];
-        } while (definitionsById.get(identifier).length);
+          identifier = (host ? host + '-' : '') + ++hosts[host]
+        } while (definitionsById.get(identifier).length)
       }
 
-      var newDefinition = {
+      definition = {
         type: 'definition',
         identifier: identifier,
         title: title,
         url: link
-      };
+      }
 
-      newDefinitions.push(newDefinition);
-      definitionsById.add(newDefinition);
-      definitionsByLink.add(newDefinition);
+      definitions.push(definition)
+      definitionsById.add(definition)
+      definitionsByUrl.add(definition)
 
-      return identifier;
-    }
-  };
-};
+      return identifier
 
+      function some(def) {
+        if (def.title === title) {
+          identifier = def.identifier
+          return true
+        }
+
+        return false
+      }
+    }
+  }
+}
 
-function urlHost (link) {
-  var host = url.parse(link).host;
-  return host ? path.parse(host).name : '';
+function urlHost(link) {
+  var host = url.parse(link).host
+  return host ? path.parse(host).name : ''
 }
diff --git a/package.json b/package.json
index ff1309e..186c3f6 100644
--- a/package.json
+++ b/package.json
@@ -36,10 +36,33 @@
     "unist-util-index": "^1.0.0"
   },
   "devDependencies": {
+    "prettier": "^1.14.2",
     "remark": "^9.0.0",
-    "tape": "^4.0.2"
+    "remark-cli": "^5.0.0",
+    "remark-preset-wooorm": "^4.0.0",
+    "tape": "^4.0.2",
+    "xo": "^0.22.0"
   },
   "scripts": {
-    "test": "node test/test"
+    "format": "remark *.md -qfo && prettier --write \"**/*.js\" && xo --fix",
+    "test-api": "node test/test",
+    "test": "npm run format && npm run test-api"
+  },
+  "prettier": {
+    "tabWidth": 2,
+    "useTabs": false,
+    "singleQuote": true,
+    "bracketSpacing": false,
+    "semi": false,
+    "trailingComma": "none"
+  },
+  "xo": {
+    "prettier": true,
+    "esnext": false
+  },
+  "remarkConfig": {
+    "plugins": [
+      "preset-wooorm"
+    ]
   }
 }
diff --git a/test/test.js b/test/test.js
index 526e7aa..081f90b 100644
--- a/test/test.js
+++ b/test/test.js
@@ -1,78 +1,90 @@
-'use strict';
-
-var defsplit = require('..');
-
-var test = require('tape'),
-    remark = require('remark');
-
-var fs = require('fs');
-
-
-test(function (t) {
-  var input = readInput('wonders/wonders'),
-      output = readOutput('wonders/wonders');
-
-  t.equal(process(input), output, 'extracts destinations');
-  t.equal(process(output), output, 'idempotence');
-  t.end();
-});
-
-
-test('identifier clashes', function (t) {
-  t.equal(process(readInput('clash/different-sections')),
-          readOutput('clash/different-sections'),
-          'extracted definitions in different sections do not clash');
-  t.equal(process(readInput('clash/other-definitions')),
-          readOutput('clash/other-definitions'),
-          'new-born definitions don\'t clash with existing ones');
-  t.equal(process(readInput('clash/reuse')), readOutput('clash/reuse'),
-          'reuse existing identifiers');
-  t.equal(process(readInput('clash/object-prototype-props')),
-          readOutput('clash/object-prototype-props'),
-          'no clashes with Object.prototype property names');
-  t.end();
-});
-
-
-test('options.id', function (t) {
-  t.equal(process(readInput('options/id-multi'),
-                  { id: ['travis-badge', 'travis'] }),
-          readOutput('options/id-multi'), 'works with array of values');
-  t.equal(process(readInput('options/id-single'), { id: 'travis-ci-0' }),
-          readOutput('options/id-single'), 'works with a single value');
-  t.equal(process(readInput('options/object-prototype-props'),
-                  { id: ['__proto__', 'constructor'] }),
-          readOutput('options/object-prototype-props'),
-          'works with Object.prototype property names');
-  t.end();
-});
-
-
-test('local links', function (t) {
-  t.equal(process(readInput('local/example')),
-          readOutput('local/example'),
-          'should support links to local things');
-  t.end();
-});
-
-
-function process (src, opts) {
-  return remark().use(defsplit, opts).processSync(src).toString();
+'use strict'
+
+var fs = require('fs')
+var path = require('path')
+var test = require('tape')
+var remark = require('remark')
+var defsplit = require('..')
+
+test('remark-defsplit', function(t) {
+  t.equal(
+    process(readInput('wonders/wonders')),
+    readOutput('wonders/wonders'),
+    'extracts destinations'
+  )
+
+  t.equal(
+    process(readOutput('wonders/wonders')),
+    readOutput('wonders/wonders'),
+    'idempotence'
+  )
+
+  t.equal(
+    process(readInput('clash/different-sections')),
+    readOutput('clash/different-sections'),
+    'extracted definitions in different sections do not clash'
+  )
+
+  t.equal(
+    process(readInput('clash/other-definitions')),
+    readOutput('clash/other-definitions'),
+    'new-born definitions don’t clash with existing identifiers'
+  )
+
+  t.equal(
+    process(readInput('clash/reuse')),
+    readOutput('clash/reuse'),
+    'identifier reuses existing identifiers'
+  )
+
+  t.equal(
+    process(readInput('clash/object-prototype-props')),
+    readOutput('clash/object-prototype-props'),
+    'identifier doesn’t clash with Object.prototype property names'
+  )
+
+  t.equal(
+    process(readInput('options/id-multi'), {id: ['travis-badge', 'travis']}),
+    readOutput('options/id-multi'),
+    '`options.id` works with array of values'
+  )
+
+  t.equal(
+    process(readInput('options/id-single'), {id: 'travis-ci-0'}),
+    readOutput('options/id-single'),
+    '`options.id` works with a single value'
+  )
+
+  t.equal(
+    process(readInput('options/object-prototype-props'), {
+      id: ['__proto__', 'constructor']
+    }),
+    readOutput('options/object-prototype-props'),
+    '`options.id` works with Object.prototype property names'
+  )
+
+  t.equal(
+    process(readInput('local/example')),
+    readOutput('local/example'),
+    'should support links to local things'
+  )
+
+  t.end()
+})
+
+function process(src, opts) {
+  return remark()
+    .use(defsplit, opts)
+    .processSync(src)
+    .toString()
 }
 
-
-function readInput (test) {
-  return fs.readFileSync(dataFile(test), { encoding: 'utf8' });
+function readInput(fp) {
+  return fs.readFileSync(path.join(__dirname, 'data', fp + '.md'))
 }
 
-
-function readOutput (test) {
-  // Normalize style.
-  return remark().processSync(fs.readFileSync(dataFile(test + '-output'),
-                                        { encoding: 'utf8' })).toString();
-}
-
-
-function dataFile (test) {
-  return __dirname + '/data/' + test + '.md';
+function readOutput(fp) {
+  return remark()
+    .processSync(readInput(fp + '-output'))
+    .toString()
 }