From 933152ceff7fee2ecd53d7edb9e970b61b1957ef Mon Sep 17 00:00:00 2001 From: Jack Bates Date: Wed, 9 Feb 2022 16:10:36 -0700 Subject: [PATCH] Make test concise --- lib/find/config.js | 1 + test/fixtures/other-branches.md | 8 ++++++++ test/index.js | 35 ++++++--------------------------- 3 files changed, 15 insertions(+), 29 deletions(-) create mode 100644 test/fixtures/other-branches.md diff --git a/lib/find/config.js b/lib/find/config.js index e5ff9e9..4c6e1f9 100644 --- a/lib/find/config.js +++ b/lib/find/config.js @@ -48,6 +48,7 @@ export function config(ctx) { if (info.type in viewPaths) { urlConfig.prefix = new URL(info.browse({treepath: viewPaths[info.type]})).pathname + '/' + // GitHost#browse() omits the "blob" segment from branch-less URLs. if (!info.committish) { urlConfig.prefix += viewPaths[info.type] + '/' } diff --git a/test/fixtures/other-branches.md b/test/fixtures/other-branches.md new file mode 100644 index 0000000..d81fd92 --- /dev/null +++ b/test/fixtures/other-branches.md @@ -0,0 +1,8 @@ +# Links to other branches + +- [Same branch, working link](https://github.com/wooorm/test/blob/main/examples/github.md#hello). +- [Other branch, working link](https://github.com/wooorm/test/blob/foo-bar/examples/github.md#hello): Nothing to ignore. +- [Same branch, unknown heading](https://github.com/wooorm/test/blob/main/examples/github.md#world): Should be reported. +- [Other branch, unknown heading](https://github.com/wooorm/test/blob/foo-bar/examples/github.md#world): Should be ignored. +- [Same branch, unknown file](https://github.com/wooorm/test/blob/main/examples/world.md#hello): Should be reported. +- [Other branch, unknown file](https://github.com/wooorm/test/blob/foo-bar/examples/world.md#hello): Should be ignored. diff --git a/test/index.js b/test/index.js index 7114831..458a84a 100644 --- a/test/index.js +++ b/test/index.js @@ -1017,41 +1017,18 @@ test('links to other branches', async (t) => { '"../../index.js=repository:\\"wooorm/test#main\\""', '--use', '../sort.js', - 'github.md', - 'examples/github.md' + 'other-branches.md' ].join(' ') ) t.deepEqual( strip(stderr), [ - 'examples/github.md', - ' 5:37-5:51 warning Link to unknown heading: `world` missing-heading remark-validate-links', - ' 15:34-15:91 warning Link to unknown file: `../world.md` missing-file remark-validate-links', - ' 19:10-19:29 warning Link to unknown file: `../world.md` missing-file remark-validate-links', - ' 29:10-29:33 warning Link to unknown heading in `../github.md`: `world` missing-heading-in-file remark-validate-links', - ' 31:10-31:71 warning Link to unknown heading in `../github.md`: `world` missing-heading-in-file remark-validate-links', - ' 35:10-35:32 warning Link to unknown file: `../world.md` missing-file remark-validate-links', - ' 35:10-35:32 warning Link to unknown heading in `../world.md`: `hello` missing-heading-in-file remark-validate-links', - ' 37:10-37:70 warning Link to unknown file: `../world.md` missing-file remark-validate-links', - ' 37:10-37:70 warning Link to unknown heading in `../world.md`: `hello` missing-heading-in-file remark-validate-links', - '', - 'github.md', - ' 5:37-5:51 warning Link to unknown heading: `world` missing-heading remark-validate-links', - ' 21:34-21:100 warning Link to unknown file: `examples/world.md` missing-file remark-validate-links', - ' 23:34-23:82 warning Link to unknown file: `examples/world.md` missing-file remark-validate-links', - ' 27:10-27:37 warning Link to unknown file: `examples/world.md` missing-file remark-validate-links', - ' 29:10-29:35 warning Link to unknown file: `examples/world.md` missing-file remark-validate-links', - ' 41:10-41:41 warning Link to unknown heading in `examples/github.md`: `world` missing-heading-in-file remark-validate-links', - ' 43:10-43:39 warning Link to unknown heading in `examples/github.md`: `world` missing-heading-in-file remark-validate-links', - ' 45:10-45:80 warning Link to unknown heading in `examples/github.md`: `world` missing-heading-in-file remark-validate-links', - ' 49:10-49:40 warning Link to unknown file: `examples/world.md` missing-file remark-validate-links', - ' 49:10-49:40 warning Link to unknown heading in `examples/world.md`: `hello` missing-heading-in-file remark-validate-links', - ' 51:10-51:38 warning Link to unknown file: `examples/world.md` missing-file remark-validate-links', - ' 51:10-51:38 warning Link to unknown heading in `examples/world.md`: `hello` missing-heading-in-file remark-validate-links', - ' 53:10-53:79 warning Link to unknown file: `examples/world.md` missing-file remark-validate-links', - ' 53:10-53:79 warning Link to unknown heading in `examples/world.md`: `hello` missing-heading-in-file remark-validate-links', + 'other-branches.md', + ' 5:3-5:100 warning Link to unknown heading in `examples/github.md`: `world` missing-heading-in-file remark-validate-links', + ' 7:3-7:96 warning Link to unknown file: `examples/world.md` missing-file remark-validate-links', + ' 7:3-7:96 warning Link to unknown heading in `examples/world.md`: `hello` missing-heading-in-file remark-validate-links', '', - '⚠ 23 warnings', + '⚠ 3 warnings', '' ].join('\n'), 'should ignore links to other branches'