Skip to content
This repository was archived by the owner on Aug 2, 2025. It is now read-only.

Conversation

@JWF-Spiria
Copy link
Contributor

Return the chain promise to propagate the throw error and continue the chaining normally.
Fix the Unhandled Promise Rejection

Closes #906

@semoal
Copy link
Member

semoal commented Jul 1, 2021

Looks great to me and has a lot of sense, could you add a test for this?
I have a plan to introduce a big feature inside loading plugin and I don't want to break any suit case

@JWF-Spiria
Copy link
Contributor Author

Well I don't know if it would add anything. You already have tests that cover the propagation of the effect error. The new code simply prevent the warning.

@JWF-Spiria
Copy link
Contributor Author

I guess we could put this in the describe function?

process.on('unhandledRejection', (err) => { fail(err); });

@semoal semoal mentioned this pull request Jul 1, 2021
15 tasks
@semoal semoal added this to the 2.1.0 milestone Jul 1, 2021
@semoal semoal changed the title fix: return chain promises effect fix: loading plugin returns chain of promises effect Jul 6, 2021
@semoal semoal merged commit aba57b3 into rematch:main Jul 6, 2021
@semoal
Copy link
Member

semoal commented Jul 6, 2021

Thanks for the contribution mate, I'll release this with 2.1.0 in aprox 1 week more or less it will be released. :)

@JWF-Spiria JWF-Spiria deleted the loading-plugin-chain branch July 6, 2021 17:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unhandled promise rejection with the Loading plugin

2 participants