New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: @rematch/loading with type: 'full' returns success/error/loading #922
Merged
semoal
merged 8 commits into
main
from
semoal/feat-detailed-success-loading-error-plugin
Aug 12, 2021
Merged
feat: @rematch/loading with type: 'full' returns success/error/loading #922
semoal
merged 8 commits into
main
from
semoal/feat-detailed-success-loading-error-plugin
Aug 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
b10cc1b
to
c713099
Compare
How about 'detail' or 'details'? |
tianzhich
requested changes
Aug 12, 2021
plz check my commits and comments @semoal. |
semoal
added a commit
that referenced
this pull request
Aug 31, 2021
#922) Co-authored-by: tianzhich <zhi.tian@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally found some time to work on this cool feature.
This introduces a little breaking change (which is not, because under the hood adapts the configuration to match the newest one if users are using the old one)
Basically now @rematch/loading plugin accepts a
type
property (By default is type: boolean)This property accepts:
'number'
,'boolean'
,'full'
{ type: "full" }
Basically returns
{ success: false, loading: true, error: false }
, if the effect promise returns an error the error response is added to error.Works fine with Typescript as far as I could check.
Pending
Will resolve #877