Too many old issues. We need to cleanup. #1104

Closed
piejanssens opened this Issue May 13, 2013 · 46 comments

Comments

Projects
None yet
Collaborator

piejanssens commented May 13, 2013

  • Remove fixed issues
  • Remove non-issues (user related)
  • Remove duplicates
  • Assign tags (bug, feature request, critical, ...)
Owner

rembo10 commented May 13, 2013

Yeah this needs to be done so I can focus on the important stuff first. If
anyone's up for helping, it would be much appreciated!

On Mon, May 13, 2013 at 6:01 PM, Pieter Janssens
notifications@github.comwrote:

  • Remove fixed issues
  • Remove non-issues (user related)
  • Remove duplicates
  • Assign tags (bug, feature request, critical, ...)


Reply to this email directly or view it on GitHubhttps://github.com/rembo10/headphones/issues/1104
.

Collaborator

piejanssens commented May 13, 2013

I'd be glad to help you with this for as much as I am able to.

Owner

rembo10 commented May 13, 2013

Yeah just if you (or anyone else) notices dupes or issues that have already
been fixed it'll make my life a lot easier

On Mon, May 13, 2013 at 7:02 PM, Pieter Janssens
notifications@github.comwrote:

I'd be glad to help you with this for as much as I am able to.


Reply to this email directly or view it on GitHubhttps://github.com/rembo10/headphones/issues/1104#issuecomment-17807353
.

Collaborator

piejanssens commented May 13, 2013

I think it's easiest to reference the issues in this issue. Agree?

Owner

rembo10 commented May 13, 2013

Thank you so much!

On Mon, May 13, 2013 at 7:46 PM, Pieter Janssens
notifications@github.comwrote:

Irrelevant anymore:

Dead?:
#597 #597

Fixed:
#384 #384
#365 #365
#310 #310
#460 #460
#397 #397
#500 #500
#628 #628
#626 https://%20github.com/rembo10/headphones/issues/626
#618 #618

Close (non issue)
#499 #499

Close (no response, one mention):
#350 #350

Close (no response)
#306 #306

Close (it's a no go)
#314 #314
#489 #489
#439 #439

Probably ok:
#288 #288
#504 #504
#503 #503

Change to request:
#601 #601
#602 #602
#607 #607
#608 #608
#378 #378
#376 #376
#372 #372
#320 #320
#464 #464
#465 #465
#463 #463
#437 #437
#416 #416
#412 #412
#396 https://github.com/rembo10/headphones/iss%20ues/396
#395 #395
#561 #561 <-- critical
(annoying :p)
#549 #549
#538 #538
#529 #529
#521 #521
#515 #515
#507 #507
#481 #481


Reply to this email directly or view it on GitHubhttps://github.com/rembo10/headphones/issues/1104#issuecomment-17809207
.

Collaborator

piejanssens commented May 13, 2013

What I noticed most:

  • A lot of special character issues (make it fully unicode compliant)
  • A lot of wrong media type issues (add standard ignore words like dvd,mp4,dvdr,mkv,x264,...)
  • A lot of file and folder permission issues (I think a lot of the issues are not really HP issues..)

Irrelevant anymore:
#594
#591
#703
#678
#869

Dead?:
#597

Fixed:
#959
#836
#1018
#731
#384
#365
#310
#460
#397
#500
#628
#626
#793
#618

Close (non issue)
#499

Close (no response, one mention):
#350
#593

Close (no response)
#306

Close (it's a no go)
#314
#489
#439

Probably ok:
#288
#504
#503

Change to request (rembo, you should close label a few of them as futuristic requests or close them, focus on getting a 1.0 version, leave the bells and whistles for later)
#975
#837
#860
#865
#727
#601
#602
#607
#608
#378
#376
#372
#320
#464
#465
#463
#437
#416
#412
#396
#940
#395
#946
#561 <-- critical (annoying :p)
#549
#538
#529
#1020
#521
#515
#507
#481
#580
#569
#672
#671
#663
#655
#785
#774
#910

#481 is critical for me :)

Issue #770 is important mainly because it prevents people who use the public MusicBrainz server from updating artists and in turn downloading newly released albums.

Duplicates may include #1081 #1023 #1034 #931 #782 #553 #504 #393

Possible solutions: #946 #880 #574 #466 #437

There are probably other duplicates of this issue, since this HTTP 503 error has been around for well over 6 months now. These were a couple that I could find at first glance.

To me these two issues are still open:

#945
#943

Both relate to the automatic updating which does not work. Ideally, I would like to start with a clean slate.

Owner

rembo10 commented May 22, 2013

@achmetinternet: have you made any local changes to your copy of headphones?

On Tue, May 21, 2013 at 8:35 PM, achmetinternet notifications@github.comwrote:

To me these two issues are still open:

#945 #945
#943 #943

Both relate to the automatic updating which does not work. Ideally, I
would like to start with a clean slate.


Reply to this email directly or view it on GitHubhttps://github.com/rembo10/headphones/issues/1104#issuecomment-18208812
.

I just reinstalled it completely and it is fine now but I believe the search function does not find anything, e.g. on nzb.su.

I checked my credentials and used https://www.nzb.su and got the following error:

2013-05-22 07:35:31 WARNING Error fetching data from http://nzb.su: HTTP Error 403: Forbidden

And a manual search found the album I am looking for on rutracker but it seems via the log that it is not picking it up. Try it with Oliver Schories (artist) and EXIT (album) and you get the following errors:

2013-05-22 07:49:45 INFO No valid results found from rutracker.org
2013-05-22 07:49:40 INFO Parsing results from rutracker.org

EDIT: I unchecked the nzbX box and then re-checked it and now it searches that site correctly but in the log it does not mention any of the torrent sites being searched. Two suggestions:

  1. a debug function with more detailed info, e.g. from which search provider the torrent/nzb was downloaded from
    EDIT: I saw that in the history tab I can see where it was downloaded from but still the option for a debug log would be nice
  2. priority of certain sites, i.e. I would prefer rutracker.org to be searched first

Last but not least: I LOVE THIS PROGRAM!

nzb.su has a very limited API hit count for non-paying users. You probably already used your daily maximum. I believe downloading any nzb from there also requires a payment.

I am a VIP user and I got 5000 API hits per day...I only used 145 so far and got only 85 grabs in total since the beginning so I doubt that is the issue.

Collaborator

AdeHub commented May 26, 2013

@achmetinternet: re: rutracker Oliver Schories EXIT

This is because there is a track count check between headphones and rutracker. For this album headphones has picked up the default release from musicbrainz which has 13 tracks but the torrents on rutracker have 14 tracks. To get it to work - in headphones select 'Choose Alternate Release' and pick the release with 14 tracks

NZB.su banned Headphones back in the day due to too many API hits. This was never resolved, or if it was, it was never unbanned by NZB.su. That's what the forbidden error is from.

Thanks for the help! Too bad with nzb.su. :(

Owner

rembo10 commented May 27, 2013

Yeah - i added in the useragent and set a hard limit on the amount of
requests the app can make, but they're still blocking us. not sure the best
solution

On Mon, May 27, 2013 at 2:35 PM, achmetinternet notifications@github.comwrote:

Thanks for the help! Too bad with nzb.su. :(


Reply to this email directly or view it on GitHubhttps://github.com/rembo10/headphones/issues/1104#issuecomment-18486128
.

How is e.g. CouchPotato dealing with this? Any idea?

Owner

rembo10 commented May 27, 2013

ah, that's a good question. i have no idea. the ratelimiting isn't great
(maybe I can restrict it to like, 10 api hits a day or something)

On Mon, May 27, 2013 at 5:19 PM, achmetinternet notifications@github.comwrote:

How is e.g. CouchPotato dealing with this? Any idea?

2013/5/27 rembo10 notifications@github.com

Yeah - i added in the useragent and set a hard limit on the amount of
requests the app can make, but they're still blocking us. not sure the
best
solution

On Mon, May 27, 2013 at 2:35 PM, achmetinternet <
notifications@github.com>wrote:

Thanks for the help! Too bad with nzb.su. :(


Reply to this email directly or view it on GitHub<
https://github.com/rembo10/headphones/issues/1104#issuecomment-18486128>

.


Reply to this email directly or view it on GitHub<
https://github.com/rembo10/headphones/issues/1104#issuecomment-18491696>
.


Reply to this email directly or view it on GitHubhttps://github.com/rembo10/headphones/issues/1104#issuecomment-18491952
.

My take was that the owner of NZB.su wanted you to contact him directly if/when it was resolved so the ban could be lifted.

One more issue is related to the renamer:

#954

How is this progressing?

DjSlash commented Aug 30, 2013

@rembo10 This issue had a good start, but got to an halt. There is a definitive need of weeding out old issues, before there even can begin to work on stuff (well, in my opinion that is). The issue within this issue should have it's own issue. I know how demotivational it is to work through old stuff and how enjoyable it is to implement new code, but it has to be done. If you need help with anything, ask! I'm sure people do want you to get sorted. Award the work that @piejanssens did for you in #1104 (comment) and use his list to close some issues.

Owner

rembo10 commented Aug 31, 2013

I think you're right. It's hard to keep on top of these issues when there's
just so much stuff open. Gonna start getting into it this weekend. Expect a
lot of cleanup over the next few days
On Aug 30, 2013 5:19 PM, "Rutger van Sleen" notifications@github.com
wrote:

@rembo10 https://github.com/rembo10 This issue had a good start, but
got to an halt. There is a definitive need of weeding out old issues,
before there even can begin to work on stuff (well, in my opinion that is).
The issue within this issue should have it's own issue. I know how
demotivational it is to work through old stuff and how enjoyable it is to
implement new code, but it has to be done. If you need help with anything,
ask! I'm sure people do want you to get sorted. Award the work that
@piejanssens https://github.com/piejanssens did for you in #1104#1104 (comment) use his list to close some issues.


Reply to this email directly or view it on GitHubhttps://github.com/rembo10/headphones/issues/1104#issuecomment-23556011
.

Collaborator

piejanssens commented Aug 31, 2013

Rembo,

I think the best thing you can do is close personal/user (non HP) issues immediately. Do a big cleanup, use badges for critical, feature request and dont be afraid to turn down crazy feature requests. It's your project.
I would also just close old issues, the user will get notified of this and when he comed back saying he still experience the issue then you can simply reopen it.

Verstuurd vanaf mijn iPhone

Op 31-aug.-2013 om 11:47 heeft rembo10 notifications@github.com het volgende geschreven:

I think you're right. It's hard to keep on top of these issues when there's
just so much stuff open. Gonna start getting into it this weekend. Expect a
lot of cleanup over the next few days
On Aug 30, 2013 5:19 PM, "Rutger van Sleen" notifications@github.com
wrote:

@rembo10 https://github.com/rembo10 This issue had a good start, but
got to an halt. There is a definitive need of weeding out old issues,
before there even can begin to work on stuff (well, in my opinion that is).
The issue within this issue should have it's own issue. I know how
demotivational it is to work through old stuff and how enjoyable it is to
implement new code, but it has to be done. If you need help with anything,
ask! I'm sure people do want you to get sorted. Award the work that
@piejanssens https://github.com/piejanssens did for you in #1104#1104 (comment) use his list to close some issues.


Reply to this email directly or view it on GitHubhttps://github.com/rembo10/headphones/issues/1104#issuecomment-23556011
.


Reply to this email directly or view it on GitHub.

Owner

rembo10 commented Aug 31, 2013

Good call. I saw you were doing that for a few issues. What do you think is
a good way to handle those types of questions (how do I install type
questions)?
On Aug 31, 2013 3:23 PM, "Pieter Janssens" notifications@github.com wrote:

Rembo,

I think the best thing you can do is close personal/user (non HP) issues
immediately. Do a big cleanup, use badges for critical, feature request and
dont be afraid to turn down crazy feature requests. It's your project.
I would also just close old issues, the user will get notified of this and
when he comed back saying he still experience the issue then you can simply
reopen it.

Verstuurd vanaf mijn iPhone

Op 31-aug.-2013 om 11:47 heeft rembo10 notifications@github.com het
volgende geschreven:

I think you're right. It's hard to keep on top of these issues when
there's
just so much stuff open. Gonna start getting into it this weekend.
Expect a
lot of cleanup over the next few days
On Aug 30, 2013 5:19 PM, "Rutger van Sleen" notifications@github.com
wrote:

@rembo10 https://github.com/rembo10 This issue had a good start,
but
got to an halt. There is a definitive need of weeding out old issues,
before there even can begin to work on stuff (well, in my opinion that
is).
The issue within this issue should have it's own issue. I know how
demotivational it is to work through old stuff and how enjoyable it is
to
implement new code, but it has to be done. If you need help with
anything,
ask! I'm sure people do want you to get sorted. Award the work that
@piejanssens https://github.com/piejanssens did for you in #1104<
https://github.com/rembo10/headphones/issues/1104#issuecomment-17810254>and
use his list to close some issues.


Reply to this email directly or view it on GitHub<
https://github.com/rembo10/headphones/issues/1104#issuecomment-23556011>
.


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHubhttps://github.com/rembo10/headphones/issues/1104#issuecomment-23603778
.

Collaborator

piejanssens commented Aug 31, 2013

Refer to readme and close. If we see that the readme isn't sufficient we'll update it.

Github issues are no support tickets ;-)

Verstuurd vanaf mijn iPhone

Op 31-aug.-2013 om 12:00 heeft rembo10 notifications@github.com het volgende geschreven:

Good call. I saw you were doing that for a few issues. What do you think is
a good way to handle those types of questions (how do I install type
questions)?
On Aug 31, 2013 3:23 PM, "Pieter Janssens" notifications@github.com wrote:

Rembo,

I think the best thing you can do is close personal/user (non HP) issues
immediately. Do a big cleanup, use badges for critical, feature request and
dont be afraid to turn down crazy feature requests. It's your project.
I would also just close old issues, the user will get notified of this and
when he comed back saying he still experience the issue then you can simply
reopen it.

Verstuurd vanaf mijn iPhone

Op 31-aug.-2013 om 11:47 heeft rembo10 notifications@github.com het
volgende geschreven:

I think you're right. It's hard to keep on top of these issues when
there's
just so much stuff open. Gonna start getting into it this weekend.
Expect a
lot of cleanup over the next few days
On Aug 30, 2013 5:19 PM, "Rutger van Sleen" notifications@github.com
wrote:

@rembo10 https://github.com/rembo10 This issue had a good start,
but
got to an halt. There is a definitive need of weeding out old issues,
before there even can begin to work on stuff (well, in my opinion that
is).
The issue within this issue should have it's own issue. I know how
demotivational it is to work through old stuff and how enjoyable it is
to
implement new code, but it has to be done. If you need help with
anything,
ask! I'm sure people do want you to get sorted. Award the work that
@piejanssens https://github.com/piejanssens did for you in #1104<
https://github.com/rembo10/headphones/issues/1104#issuecomment-17810254>and
use his list to close some issues.


Reply to this email directly or view it on GitHub<
https://github.com/rembo10/headphones/issues/1104#issuecomment-23556011>
.


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHubhttps://github.com/rembo10/headphones/issues/1104#issuecomment-23603778
.


Reply to this email directly or view it on GitHub.

Collaborator

AdeHub commented Sep 1, 2013

How about bringing the forum back?

Collaborator

piejanssens commented Sep 2, 2013

@rembo10 @AdeHub We can put the XBMC topic in the README: http://forum.xbmc.org/showthread.php?tid=103688

DjSlash commented Sep 19, 2013

@rembo10 If you want, @piejanssens (probably) and I are happy to help you weed out and label some if you give us permissions for it.

Owner

rembo10 commented Sep 19, 2013

Yeah for sure. I was meant to get into it last week but had coffee spilt
all over my laptop

Few more days til it's fixed then I'm gung ho

I really appreciate the help. I'll try to respond to stuff when I can

Thanks!
On Sep 19, 2013 5:05 PM, "Rutger van Sleen" notifications@github.com
wrote:

@rembo10 https://github.com/rembo10 If you want, @piejanssenshttps://github.com/piejanssens(probably) and I are happy to help you weed out and label some if you give
us permissions for it.


Reply to this email directly or view it on GitHubhttps://github.com/rembo10/headphones/issues/1104#issuecomment-24732507
.

Will help with testing etc. ;)

DjSlash commented Nov 24, 2013

Hey @rembo10, still your laptop not fixed? I've seen a few people who are interested in contributing to HP, but I think that it is time for some decision making. You are the person who is making the shots here. Others need to know what your thoughts are, so they can help you with that. And in my opinion you shouldn't be answering new issues at this moment, but instead get the old rumble out of the way. As most people are going to consume the program and not writing code for it, you and a few others need to do that writing. That's why you need to acknowledge issues that are bugs which are going to be fixed or not and with what priority.

I know how it is to be swamped, especially without proper equipment. And I also don't doubt you are putting your best efforts in to it, but try to prioritize. I wouldn't like to see this project to get lost, because it's a great idea.

+1; I'm willing to contribute as well.

Owner

rembo10 commented Nov 25, 2013

Yeah still no laptop. Long story. I have a phone and an Internet Cafe.

I have been mentally going over what needs to be done and I think I have a
pretty good sense of it.

In a few hours I'm going to start pulling in stuff to the develop branch.

If I could have some help putting together a list of the most pressing
issues at least ill have a good idea of what to work on next and what is
urgent (although like I said - I have a good sense of it but others
opinions would be helpful)

Sorry for dropping the ball on this, and thanks for the help!
On Nov 25, 2013 3:00 AM, "Leonardo Mosquera" notifications@github.com
wrote:

+1; I'm willing to contribute as well.


Reply to this email directly or view it on GitHubhttps://github.com/rembo10/headphones/issues/1104#issuecomment-29166694
.

DjSlash commented Nov 25, 2013

I'd like to suggest the following:

  1. Go through the list that @piejanssens made for you in this issue. Others shouldn't need to do that work again.
  2. Go through the current pull requests. Either merge or close them.
  3. Then write down somewhere what your thoughts are, others can contribute to that. Best is to categorize so milestones can be created.
  4. Add collaborators to help out with issues.

I'd help to sort through issues (not a developer though :) or maybe even with a laptop. Acer?

Related: albums from musicbrainz do not display.

#1034
#632
#1339
#1271

nivong commented Jan 19, 2014

still an issue clean stuff up rembo

Contributor

theguardian commented Jan 22, 2014

Yeah we need to clean up all these issues. Tagging would be a good start. I'd be happy to help out - I'm actually a project manager by trade. The following information should be required with any new issue creation.

Environment:
Linux
Mac
Windows

Headphones Subsystems:
UI/UX
Scanning
Importing
Snatching
Processing

And whether it's a fix or an idea.
Bug
Feature Request

Then we need to decide whether to fix/add/ignore, and assign priority.
We can get community experts in each line item to monitor these tags and plow through them quickly.

Like I said, I'm willing to help out. @rembo10, you should let the community know whether you intend on giving some of us access/ability to make your/our life easier or if we should carry on our merry way. Headphones works 100% fine for me and I'd like that to be the case for everyone.

Owner

rembo10 commented Jan 22, 2014

Yeah - I think also we need to create a support forum or something where users can help other users with non-technical issues (setting up, config stuff, whatever, basically anything that’s not a bug or feature request)

Also something that should be required is version (zip, git, syno package, exe), and version number if available.

I’d love to have you guys help with this if you’re up for it! Let me just figure out how to grant access and we can get started!

On Jan 22, 2014, at 8:28 AM, Justin Evans notifications@github.com wrote:

Yeah we need to clean up all these issues. Tagging would be a good start. I'd be happy to help out - I'm actually a project manager by trade. The following information should be required with any new issue creation.

Environment:
Linux
Mac
Windows

Headphones Subsystems:
UI/UX
Scanning
Importing
Snatching
Processing

And whether it's a fix or an idea.
Bug
Feature Request

Then we need to decide whether to fix/add/ignore, and assign priority.
We can get community experts in each line item to monitor these tags and plow through them quickly.

Like I said, I'm willing to help out. @rembo10, you should let the community know whether you intend on giving some of us access/ability to make your/our life easier or if we should carry on our merry way. Headphones works 100% fine for me and I'd like that to be the case for everyone.


Reply to this email directly or view it on GitHub.

nivong commented Jan 22, 2014

@rembo10
this should get you on your way:
https://help.github.com/articles/how-do-i-add-a-collaborator

Mabye add @theguardian as an code editor so he can work his magic ? also add the version number to everline in the log (same as the date and time) this way you always no the version number.

DjSlash commented Jan 26, 2014

Rembo, this is the last time I'm going to put something here. Over the last few months people have offered to help out and you have been handed information how to do that. Although I know that you have had some issues with your laptop and I also know that it takes time to answer every thing that comes with a project, you are promising the same things over and over, which is just frustrating for people who were willing to help out (past tense is in purpose). Know what you can and can't do and just say it. From what I see, you just want to please everyone and just say yes to anything that comes by. Take matters in hand, prioritise and put your words where your mouth is, please!

Best of luck.

Wait, what? That's it? I read through all that and now its 3 months stale on the above post? So is the project dead then? Man, that sucks.

I was just trying to find a forum where I could get some help with some weirdness. All I can find is this and a super long thread on xmbc (which is pretty odd because its only quasi related in a loose sense) where there's all questions and no answers.

So I guess the forum never got setup?

This seems like WAY too awesome of a project to just go flapping in the wind, no?

Well every month or so a couple of pull requests get merged into master, so there is some activity somewhere, but it's not nearly as structured and well-organized as it could be.

Owner

rembo10 commented Apr 28, 2014

That might be true (about it not being as strutted & organized as it could be), but it's been more than just pull requests.

Support isn't really great though, but there is info floating around on how to set everything up. I'm working more on fixing bugs (and that's really what the github issue tracker is for) than offering support, although i try to help out when i can.

i'm gonna close this issue. i'm working through things...... cheers

@rembo10 rembo10 closed this Apr 28, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment