Extract out BuildVolume #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 3bb4e69): https://gcode-preview--pr188-extract-build-volume-ytlmsfbj.web.app (expires Mon, 11 Nov 2024 03:30:54 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 59bd114ae4847b32c2bba0b68620b9069a3e3531 |
Member
|
I think it's fine for now, separating it out as a util. Eventually we'd want to move to a scheme where we add/remove objects like a build plate to the scene. Also it might be better to separate the axes from the build plate, eventually that is. |
Collaborator
Author
|
Agreed, they could all be separated. In a way, I find it elegant to have the build volume in a single object but with different methods to represent it on the scene. They all use the same x,y and z values. |
# Conflicts: # src/webgl-preview.ts
sophiedeziel
force-pushed
the
extract-build-volume
branch
from
0d1558f to
3bb4e69
Compare
Member
|
@sophiedeziel this LGTM. Agree to merge? |
Collaborator
Author
|
Yes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explored in #169, I've extracted out the build volume to encapsulate the attributes and geometry building.