Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 1024 limit on cpu shares #1124

Merged
merged 1 commit into from Apr 17, 2018
Merged

Remove 1024 limit on cpu shares #1124

merged 1 commit into from Apr 17, 2018

Conversation

hamiltop
Copy link
Member

  • Is your change backwards compatible? Would this require any migration steps? Will any changes be required in the CLI?
    Yes, all existing valid constraints will still be valid.
  • Does your change require changes to the documentation? Does the quickstart guide need to be updated?
    I don't think so. The comments are updated, the error message is updated, and I can't find a reference to the old limit in the quickstart guide.
  • Did you add appropriate test coverage? Submissions that add features or change core functionality will not be accepted without sufficient tests. We favor stability over anything else.
    tests were updated appropriately
  • Did you update the CHANGELOG?
    Not yet

ejholmes
ejholmes approved these changes Apr 17, 2018
View reviewed changes
Copy link
Contributor

@ejholmes ejholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @hamiltop.

@ejholmes ejholmes merged commit 224f6b0 into master Apr 17, 2018
@ejholmes ejholmes deleted the remove_cpu_constraint_upper_bound branch April 17, 2018 04:35
leelynne pushed a commit to textioHQ/empire that referenced this pull request Oct 2, 2018
@hamiltop
Remove 1024 limit on cpu shares (remind101#1124)
e837c80
coilysiren pushed a commit to textioHQ/empire that referenced this pull request Mar 23, 2019
Merge pull request remind101#1124 from remind101/remove_cpu_constrain…
6d29b89 
…t_upper_bound

Remove 1024 limit on cpu shares
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejholmes ejholmes ejholmes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hamiltop @ejholmes