Skip to content

Loading…

Model.save does not return false if there are any errors present #36

Closed
calmyournerves opened this Issue · 4 comments

3 participants

@calmyournerves

Is there any reason why the .save method in lib/her/model/orm.rb does not return false if there are any errors (self.errors)?
Making it return true or false instead of self would make it more similar to the way Rails works.

Cheers!

@luxflux

Any news on this one? Would be interested too. Would you accept pull request which change this behaviour?

@remiprev remiprev closed this in 711bde3
@remiprev
Owner

Just pushed 711bde3 which fixes this issue! Thanks for the suggestion, and sorry for the delay…

@luxflux

Cool! Thank you!

@calmyournerves

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.