Model.save does not return false if there are any errors present #36

Closed
calmyournerves opened this Issue Aug 31, 2012 · 4 comments

Comments

Projects
None yet
3 participants
@calmyournerves
Contributor

calmyournerves commented Aug 31, 2012

Is there any reason why the .save method in lib/her/model/orm.rb does not return false if there are any errors (self.errors)?
Making it return true or false instead of self would make it more similar to the way Rails works.

Cheers!

@luxflux

This comment has been minimized.

Show comment
Hide comment
@luxflux

luxflux Nov 1, 2012

Any news on this one? Would be interested too. Would you accept pull request which change this behaviour?

luxflux commented Nov 1, 2012

Any news on this one? Would be interested too. Would you accept pull request which change this behaviour?

@remiprev remiprev closed this in 711bde3 Nov 2, 2012

@remiprev

This comment has been minimized.

Show comment
Hide comment
@remiprev

remiprev Nov 2, 2012

Owner

Just pushed 711bde3 which fixes this issue! Thanks for the suggestion, and sorry for the delay…

Owner

remiprev commented Nov 2, 2012

Just pushed 711bde3 which fixes this issue! Thanks for the suggestion, and sorry for the delay…

@luxflux

This comment has been minimized.

Show comment
Hide comment
@luxflux

luxflux Nov 3, 2012

Cool! Thank you!

luxflux commented Nov 3, 2012

Cool! Thank you!

@calmyournerves

This comment has been minimized.

Show comment
Hide comment
@calmyournerves

calmyournerves Nov 3, 2012

Contributor

Cheers!

Contributor

calmyournerves commented Nov 3, 2012

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment