Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the ability to parse the dom for extra attributes #122

Merged
merged 2 commits into from Jul 23, 2019

Conversation

ifiokjr
Copy link
Member

@ifiokjr ifiokjr commented Jul 23, 2019

Description

  • @remirror/core: Add getExtraAttrs method to the extension which can be used in the (Mark/Node)Extension.
  • @remirror/core: Update extraAttrs configuration to enable parsing the dom.
  • @remirror/core-extensions: Add extraAttrs to the following extensions:
    LinkExtension, ParagraphExtension, HeadingExtension.

Closes #113

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project and yarn fix runs successfully.
  • I have updated the documentation where necessary.
  • New code is unit tested and all current tests pass when running yarn test .

@ifiokjr ifiokjr changed the title Extra attrs feat: add the ability to parse the dom for extra attributes Jul 23, 2019
@ifiokjr ifiokjr added @remirror/core type: fix 🔧 A pull request that fixes a known bug. labels Jul 23, 2019
@netlify
Copy link

netlify bot commented Jul 23, 2019

Deploy preview for remirror ready!

Built with commit ca0da7d

https://deploy-preview-122--remirror.netlify.com

@ifiokjr ifiokjr removed the type: fix 🔧 A pull request that fixes a known bug. label Jul 23, 2019
@ifiokjr ifiokjr merged commit a64c8ee into master Jul 23, 2019
@ifiokjr ifiokjr deleted the extra-attrs branch July 23, 2019 03:58
@ifiokjr ifiokjr added type: feature ✨ A new feature is being added to the public API package: remirror 🟣 Label for the remirror package and all relevant scoped `@remirror/*` packages. and removed pr: feature labels Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: remirror 🟣 Label for the remirror package and all relevant scoped `@remirror/*` packages. type: feature ✨ A new feature is being added to the public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Allow additional attributes to be parsed for links
1 participant