Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple commands issue #422

Merged
merged 3 commits into from Jul 31, 2020
Merged

fix: multiple commands issue #422

merged 3 commits into from Jul 31, 2020

Conversation

ifiokjr
Copy link
Member

@ifiokjr ifiokjr commented Jul 31, 2020

Description

  • Add chain method to RemirrorTestChain and update select text to receive all for selecting all text.
  • Support chained commands and multiple command updates in controlled editors.

Fixes #418

  • Use NonChainableCommandFunction annotation to indicate commands are not chainable.

Checklist

  • I have read the contributing document.
  • My code follows the code style of this project and pnpm fix completed successfully.
  • I have updated the documentation where necessary.
  • New code is unit tested and all current tests pass when running pnpm test.

@changeset-bot
Copy link

changeset-bot bot commented Jul 31, 2020

🦋 Changeset is good to go

Latest commit: 7477b93

We got this.

This PR includes changesets to release 71 packages
Name Type
jest-remirror Major
@remirror/core Major
@remirror/core-utils Major
@remirror/extension-code Major
@remirror/extension-code-block Major
@remirror/extension-heading Major
@remirror/extension-italic Major
@remirror/extension-paragraph Major
@remirror/extension-strike Major
@remirror/extension-underline Major
remirror Major
@remirror/extension-history Major
@remirror/extension-yjs Major
@remirror/dom Major
@remirror/extension-auto-link Major
@remirror/extension-base-keymap Major
@remirror/extension-bidi Major
@remirror/extension-blockquote Major
@remirror/extension-bold Major
@remirror/extension-collaboration Major
@remirror/extension-diff Major
@remirror/extension-doc Major
@remirror/extension-drop-cursor Major
@remirror/extension-emoji Major
@remirror/extension-epic-mode Major
@remirror/extension-events Major
@remirror/extension-gap-cursor Major
@remirror/extension-hard-break Major
@remirror/extension-horizontal-rule Major
@remirror/extension-image Major
@remirror/extension-link Major
@remirror/extension-mention Major
@remirror/extension-placeholder Major
@remirror/extension-position-tracker Major
@remirror/extension-positioner Major
@remirror/extension-react-component Major
@remirror/extension-react-ssr Major
@remirror/extension-search Major
@remirror/extension-text Major
@remirror/extension-trailing-node Major
@remirror/playground Major
@remirror/preset-core Major
@remirror/preset-embed Major
@remirror/preset-list Major
@remirror/preset-react-checkbox Major
@remirror/preset-react Major
@remirror/preset-social Major
@remirror/preset-table Major
@remirror/preset-wysiwyg Major
@remirror/react-social Major
@remirror/react-wysiwyg Major
@remirror/react Major
@remirror/showcase Major
@remirror/testing Patch
@remirror/e2e Patch
jest-prosemirror Patch
prosemirror-suggest Patch
@remirror/support Patch
@remirror/storybook Patch
@remirror/website Patch
with-next Patch
@remirror/pm Major
@remirror/core-types Major
@remirror/dev Major
@remirror/i18n Major
@remirror/core-helpers Major
@remirror/react-utils Major
@remirror/theme Major
multishift Patch
test-keyboard Patch
@remirror/cli Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

@ifiokjr ifiokjr merged commit 7477b93 into next Jul 31, 2020
@ifiokjr ifiokjr deleted the multiple-command-bug branch July 31, 2020 05:02
@github-actions github-actions bot temporarily deployed to production July 31, 2020 05:08 Inactive
@ifiokjr ifiokjr added type: feature ✨ A new feature is being added to the public API and removed pr: feature labels Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature ✨ A new feature is being added to the public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling multiple commands only registers the last command
1 participant