From ba1cd3cf50465af8e1a89cc4f088c6372c10c12b Mon Sep 17 00:00:00 2001 From: Ryan Florence Date: Fri, 4 Feb 2022 12:39:10 -0700 Subject: [PATCH] fix: import history from ESM (#934) Removing closure compiiler fixes the problem. The build is now much faster and the resulting file size difference is marginal. --- package.json | 4 ++-- scripts/rollup/history.config.js | 13 +++---------- 2 files changed, 5 insertions(+), 12 deletions(-) diff --git a/package.json b/package.json index a8141a2e..19ba6aab 100644 --- a/package.json +++ b/package.json @@ -65,10 +65,10 @@ }, "filesize": { "build/history/history.production.min.js": { - "none": "5 kB" + "none": "5.06 kB" }, "build/history/umd/history.production.min.js": { - "none": "6 kB" + "none": "6.03 kB" } } } diff --git a/scripts/rollup/history.config.js b/scripts/rollup/history.config.js index 22ae8efa..2efb94f8 100644 --- a/scripts/rollup/history.config.js +++ b/scripts/rollup/history.config.js @@ -1,5 +1,4 @@ import { babel } from '@rollup/plugin-babel'; -import compiler from '@ampproject/rollup-plugin-closure-compiler'; import copy from 'rollup-plugin-copy'; import prettier from 'rollup-plugin-prettier'; import replace from '@rollup/plugin-replace'; @@ -37,7 +36,6 @@ const modules = [ ], babelHelpers: 'runtime' }), - compiler(), copy({ targets: [ { src: 'README.md', dest: OUTPUT_DIR }, @@ -70,8 +68,7 @@ const modules = [ presets: [['@babel/preset-env', { loose: true }]], plugins: ['babel-plugin-dev-expression'], babelHelpers: 'bundled' - }), - compiler() + }) ].concat(PRETTY ? prettier({ parser: 'babel' }) : []) }; }) @@ -103,8 +100,7 @@ const webModules = [ replace({ 'process.env.NODE_ENV': JSON.stringify('development'), preventAssignment: false - }), - compiler() + }) ].concat(PRETTY ? prettier({ parser: 'babel' }) : []) }, { @@ -133,7 +129,6 @@ const webModules = [ 'process.env.NODE_ENV': JSON.stringify('production'), preventAssignment: false }), - compiler(), terser({ ecma: 8, safari10: true }) ].concat(PRETTY ? prettier({ parser: 'babel' }) : []) } @@ -160,8 +155,7 @@ const globals = [ replace({ 'process.env.NODE_ENV': JSON.stringify('development'), preventAssignment: false - }), - compiler() + }) ].concat(PRETTY ? prettier({ parser: 'babel' }) : []) }, { @@ -185,7 +179,6 @@ const globals = [ 'process.env.NODE_ENV': JSON.stringify('production'), preventAssignment: false }), - compiler(), terser() ].concat(PRETTY ? prettier({ parser: 'babel' }) : []) }