-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
docs(start/modes): fix import path #14239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(start/modes): fix import path #14239
Conversation
|
|
Hi @wo-o29, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
|
I know that's a typo or something, but the right thing to do is to use https://reactrouter.com/explanation/type-safety
|
I see you're using the Then I'll change |
…wo-o29/react-router into docs/fix-import-path-correction
./+types/... correctly
|
Thanks! |
./+types/... correctly
Summary
In the example code, the import statement was incorrectly written as:
This has been corrected to:
Reasoning
+. before a relative path is not valid syntax in JavaScript/TypeScript and will cause compilation errors.+types, so the correct relative import path should be./+types/product.tsx