Skip to content

Fix react-router-dom main entry metadata - #15238

Merged
brophdawg11 merged 5 commits into
remix-run:v7from
leo1987820:fix/react-router-dom-main-entry-3380
Jun 29, 2026
Merged

Fix react-router-dom main entry metadata#15238
brophdawg11 merged 5 commits into
remix-run:v7from
leo1987820:fix/react-router-dom-main-entry-3380

Conversation

@leo1987820

Copy link
Copy Markdown

Summary

  • point react-router-dom's CommonJS main field at the packaged ./dist/index.js file
  • add a patch change file for the package metadata fix

Verification

  • Confirmed react-router-dom@7.18.0 currently declares main: "./dist/main.js" on npm.
  • Confirmed the published tarball does not contain package/dist/main.js.
  • Confirmed the published tarball contains package/dist/index.js and package/dist/index.mjs.
  • Confirmed this branch only changes packages/react-router-dom/package.json and adds the package change file.

@remix-cla-bot

remix-cla-bot Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Hi @leo1987820,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot

remix-cla-bot Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

Comment thread packages/react-router-dom/.changes/patch-main-entry.md Outdated

@brophdawg11 brophdawg11 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brophdawg11
brophdawg11 merged commit 2ecaa1d into remix-run:v7 Jun 29, 2026
7 checks passed
@ryanflorence ryanflorence mentioned this pull request Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants