Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle encoding of dynamic params in descendant routes #9589

merged 6 commits into from Nov 18, 2022


Copy link

@brophdawg11 brophdawg11 commented Nov 14, 2022

Need to re-encode the pathname fields on internal matches for proper matching in descendant routes

Closes #9580, #9604

Copy link

changeset-bot bot commented Nov 14, 2022

🦋 Changeset detected

Latest commit: 1b2e28a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
react-router Patch
react-router-dom Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

// Re-encode pathnames that were decoded inside matchRoutes
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need these to be re-encoded so that our pathname.slice(parentPathnameBase.length) call up on line 382 is correct. It's slicing from an encoded location.pathname so needs to be using the length of an encoded parentPathnameBase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants