Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): respect replace behavior on external redirects #9654

merged 2 commits into from Nov 29, 2022


Copy link

Fixes a bug in 6.4.4-pre.1 where redirects were always replacing and causing incorrect back button behavior

  • Start at /
  • Click to /a
  • Click to /b
    • /b loader returns redirect('')
  • Land on Google
  • Back button should return you to /a

Using <Link to="/b" replace> above would cause the back button to go back to /

Copy link

changeset-bot bot commented Nov 29, 2022

🦋 Changeset detected

Latest commit: 3ba4f0b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@remix-run/router Patch
react-router Patch
react-router-dom Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 merged commit 586344f into release-6.4.4 Nov 29, 2022
2 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/redirect-replace branch November 29, 2022 16:36
@MichaelDeBoey MichaelDeBoey changed the title Respect replace behavior on external redirects fix(router): respect replace behavior on external redirects Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants