Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unstable_usePrompt #9932

merged 4 commits into from Jan 18, 2023

Add unstable_usePrompt #9932

merged 4 commits into from Jan 18, 2023


Copy link

Add an unstable version of usePrompt. Behavior gets very weird (and in some cases very wrong across browsers) if users click additional back/forward navigations while a prompt is open and there's nothing we can do about it, but this provides a simpler path than building a custom useBlocker modal/inline-prompt.

Copy link

changeset-bot bot commented Jan 18, 2023

🦋 Changeset detected

Latest commit: 9ffa109

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
react-router-dom Patch
react-router Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

@chaance chaance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Since @brophdawg11 made the PR he definitely has to address all future issues related to this topic on GitHub. By official decree.

@chaance chaance merged commit 0529002 into release-next Jan 18, 2023
2 checks passed
@chaance chaance deleted the brophdawg11/prompt branch January 18, 2023 17:56
Copy link

Hi, when will "prompt" be released for react router 6? It's actually the one thing I need in order to migrate to react 18

Copy link

machour commented Jan 30, 2023

@tan-ahmed This was published in 6.7.0, check the release notes:

@remix-run remix-run locked as resolved and limited conversation to collaborators Jan 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

Successfully merging this pull request may close these issues.

None yet

5 participants