refactor: simplify host formatting logic in FormatHostsService

- Replaced repetitive code for creating formatted hosts with a new private method, createFallbackHosts, to enhance maintainability.
- Updated the handling of empty hosts and user inbounds to utilize the new method

Author: kastov

src/modules/subscription-template/generators/format-hosts.service.ts

@@ -56,97 +56,31 @@ export class FormatHostsService {
                     break;
             }
 
-            specialRemarks.forEach((remark) => {
-                formattedHosts.push({
-                    remark,
-                    address: '0.0.0.0',
-                    port: 0,
-                    protocol: 'trojan',
-                    path: '',
-                    host: '',
-                    tls: 'tls',
-                    sni: '',
-                    alpn: '',
-                    publicKey: '',
-                    fingerprint: '',
-                    shortId: '',
-                    spiderX: '',
-                    network: 'tcp',
-                    password: {
-                        trojanPassword: '00000',
-                        vlessPassword: randomUUID(),
-                        ssPassword: '00000',
-                    },
-                });
-            });
+            formattedHosts.push(...this.createFallbackHosts(specialRemarks));
 
             return formattedHosts;
         }
 
         if (hosts.length === 0 && user.activeUserInbounds.length > 0) {
-            const emptyHostRemarks = [
-                '→ Remnawave',
-                '→ Did you forget to add hosts?',
-                '→ No hosts found',
-            ];
-
-            emptyHostRemarks.forEach((remark) => {
-                formattedHosts.push({
-                    remark,
-                    address: '0.0.0.0',
-                    port: 0,
-                    protocol: 'trojan',
-                    path: '',
-                    host: '',
-                    tls: 'tls',
-                    sni: '',
-                    alpn: '',
-                    publicKey: '',
-                    fingerprint: '',
-                    shortId: '',
-                    spiderX: '',
-                    network: 'tcp',
-                    password: {
-                        trojanPassword: '00000',
-                        vlessPassword: randomUUID(),
-                        ssPassword: '00000',
-                    },
-                });
-            });
+            formattedHosts.push(
+                ...this.createFallbackHosts([
+                    '→ Remnawave',
+                    '→ Did you forget to add hosts?',
+                    '→ No hosts found',
+                ]),
+            );
 
             return formattedHosts;
         }
 
         if (user.activeUserInbounds.length === 0) {
-            const emptyHostRemarks = [
-                '→ Remnawave',
-                '→ User has no active inbounds',
-                '→ No active inbounds found',
-            ];
-
-            emptyHostRemarks.forEach((remark) => {
-                formattedHosts.push({
-                    remark,
-                    address: '0.0.0.0',
-                    port: 0,
-                    protocol: 'trojan',
-                    path: '',
-                    host: '',
-                    tls: 'tls',
-                    sni: '',
-                    alpn: '',
-                    publicKey: '',
-                    fingerprint: '',
-                    shortId: '',
-                    spiderX: '',
-                    network: 'tcp',
-                    password: {
-                        trojanPassword: '00000',
-                        vlessPassword: randomUUID(),
-                        ssPassword: '00000',
-                    },
-                });
-            });
+            formattedHosts.push(
+                ...this.createFallbackHosts([
+                    '→ Remnawave',
+                    '→ User has no active inbounds',
+                    '→ No active inbounds found',
+                ]),
+            );
 
             return formattedHosts;
         }
@@ -374,4 +308,28 @@ export class FormatHostsService {
 
         return settingsResponse.response;
     }
+
+    private createFallbackHosts(remarks: string[]): IFormattedHost[] {
+        return remarks.map((remark) => ({
+            remark,
+            address: '0.0.0.0',
+            port: 0,
+            protocol: 'trojan',
+            path: '',
+            host: '',
+            tls: 'tls',
+            sni: '',
+            alpn: '',
+            publicKey: '',
+            fingerprint: '',
+            shortId: '',
+            spiderX: '',
+            network: 'tcp',
+            password: {
+                trojanPassword: '00000',
+                vlessPassword: randomUUID(),
+                ssPassword: '00000',
+            },
+        }));
+    }
 }