Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint support #17

Open
kuroisuna opened this issue Feb 27, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@kuroisuna
Copy link

commented Feb 27, 2019

I love this project, I'll be contributing as much as I can!

Since we do not have a node_modules how could we support a local instance of ESLint? (https://eslint.org/docs/user-guide/getting-started). And a .eslintrc config file.

For example:

.eslintrc.js
module.exports = {
  extends: "airbnb",
};

BTW, similar to Prettier, this can be done on the Editor side (https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint for example).

@asadm

This comment has been minimized.

Copy link
Member

commented Mar 1, 2019

Hello, Zero doesn’t require package.json and node_modules but you can add a basic package.json file with eslint as dependency and a npm script:

{
    ...
    "scripts": {
        "pretest": "eslint"
    }
    ...
}

I think that should do it.
Which reminds me, this project itself needs linting and clean up. I am going to check out prettier for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.