Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mob next checking out master is confusing #7

Open
alexkli opened this issue Oct 4, 2019 · 2 comments

Comments

@alexkli
Copy link

commented Oct 4, 2019

If you regularly rotate, the fact that mob next checks out master can get in the way:

  • you get back to a state before the mob session, thereby loosing all the code you have already written in the session (but you might want to look at it on your computer to research something)
  • it can confuse any open IDE if any new files are all removed
  • if a .gitignore was added part of the mob session, then mob next removes it, but leaves around whatever is ignored (e.g. a node_modules folder), which in turn will make the next mob start of the typist fail, as that one does not like any non-added and non-committed files lying around
  • if you started from a different branch than master, it's confusing that it does not return to the same one (for a typist who didn't start the first mob start and who did not set MOB_BASE_BRANCH)

IMO for the typical mob rotation it would be nice if:

  • mob next commits & pushs but stays in the mob-session branch
  • the next mob start will simply git pull the new commits from the mob-session branch
@fatso83

This comment has been minimized.

Copy link
Contributor

commented Oct 11, 2019

Ah, thanks for pointing out MOB_BASE_BRANCH! That alerted me to https://github.com/remotemobprogramming/mob/blob/master/mob.go#L13, where it's basically documented how to pass in configuration variables. That possibly makes #8 superfluous, but it's not really documented ...

@simonharrer

This comment has been minimized.

Copy link
Member

commented Oct 22, 2019

Hm, I like the idea. Will think about it. Need to handle stale 'mob-session' branches though, in case the typist ends their day with a mob next and rejoins the mob a week later. The mob-session branch on the master may already be another one, and they no longer match...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.