New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option for skipping the initial state #79

Merged
merged 2 commits into from Dec 28, 2017

Conversation

2 participants
@skddc
Copy link
Member

skddc commented Dec 26, 2017

This adds a new option for app developers, so they can hide the initial connect hint and instead show the sign-in (or choose-backend) dialog directly.

This is useful when you just want to integrate the sign-in dialog from the widget (with the errors and all), but not much else. You can try it in action with Inspektor right now (also includes the code from #78):

https://inspektor.5apps.com/

Add config option for skipping the initial state
This adds a new option for app developers, so they can hide the intial
connect hint and instead show the sign-in (or choose dialog) directly.
* @param {number} options.autoCloseAfter - Time after which the widget closes
* automatically in ms (default: 1500)
* @param {boolean} options.skipInitial - Don't show the initial connect hint,
* but show sign-in screen directly instead

This comment has been minimized.

@galfert

galfert Dec 28, 2017

Member

This is missing the default value in the description.

This comment has been minimized.

@skddc

skddc Dec 28, 2017

Member

Thanks.

@galfert

This comment has been minimized.

Copy link
Member

galfert commented Dec 28, 2017

Other than my comment this looks good to merge.

@skddc skddc merged commit a2bab68 into master Dec 28, 2017

@skddc skddc deleted the feature/skip_initial branch Dec 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment