New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #84

Closed
wants to merge 3 commits into
base: master
from

Conversation

2 participants
@skddc
Copy link
Member

skddc commented Jan 17, 2018

Our dev dependencies are pretty outdated (in Internet time). This branch already works for development, but when building production, the Uglify plugin is throwing an exception I couldn't figure out yet. If anyone has an idea about what's happening there, I'd be happy for any help.

skddc and others added some commits Jan 17, 2018

Fix production building error
Using `new UglifyJsPlugin` and the `-p` CLI option add the UglifyJSPlugin twice.

@wafflebot wafflebot bot added the in progress label Feb 1, 2019

@galfert

This comment has been minimized.

Copy link
Member

galfert commented Feb 1, 2019

Searching for the error message I found this comment.

Removing the -p CLI option from the build command fixed the error for me.

I also had to add the sourceMap: true option, otherwise it wouldn't generate the sourcemap for me anymore.

Update dependencies
Fixes security vulnerabilities
@galfert

This comment has been minimized.

Copy link
Member

galfert commented Feb 1, 2019

Even after updating, npm audit still listed 273 vulnerabilities (230 low, 34 moderate, 9 high).

So I updated some more to fix those as well.

@skddc skddc changed the title [WIP] Update dependencies Update dependencies Feb 2, 2019

@skddc

This comment has been minimized.

Copy link
Member Author

skddc commented Feb 2, 2019

Great!

I rebased on master and merged locally, and squashed the various commits into one: 27d162e

@skddc skddc closed this Feb 2, 2019

@wafflebot wafflebot bot removed the in progress label Feb 2, 2019

@skddc skddc deleted the chore/update_dependencies branch Feb 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment