New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modal backdrop #89

Merged
merged 2 commits into from Feb 5, 2019

Conversation

2 participants
@skddc
Copy link
Member

skddc commented Jan 26, 2019

Adds a dark, transparent, full-page backdrop behind the widget. It's shown by default on small screens, but not on large ones. The config option modalBackdrop can be set to true to always show it, false to never show it, or onlySmallScreens (the default).

This also changes the small-screen modal to not use the entire height of the screen, which felt a bit awkward to me in actual usage.

skddc added some commits Jan 26, 2019

Add modal backdrop
Adds a dark, transparent, full-page backdrop behind the widget. It's
shown by default on small screens, but not on large ones. The config
option `modalBackdrop` can be set to `true` to always show it, `false`
to never show it, or `onlySmallScreens` (the default).

This also changes the small-screen modal to not use the entire height of
the screen, which felt a bit awkward to me in actual usage.
Update build
Need this to deploy my apps from this branch.

@wafflebot wafflebot bot added the in progress label Jan 26, 2019

@skddc skddc requested review from galfert and lesion Feb 2, 2019

@skddc

This comment has been minimized.

Copy link
Member Author

skddc commented Feb 2, 2019

Could use a review here, so we can publish 1.4.0 including the dependency upgrades.

@galfert

galfert approved these changes Feb 5, 2019

Copy link
Member

galfert left a comment

Everything looks good to me. Couldn't find any problems.

@skddc skddc merged commit f3b4783 into master Feb 5, 2019

@skddc skddc deleted the feature/modal_backdrop branch Feb 5, 2019

@wafflebot wafflebot bot removed the in progress label Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment