New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix offline app sync error #1102

Merged
merged 3 commits into from Nov 24, 2017

Conversation

2 participants
@galfert
Copy link
Member

galfert commented Nov 24, 2017

Sometimes, when offline, instead of the ProgressEvent error the request is rejected because of a timeout instead (at least in Firexfox).

This change handles that case and prevents the Sync error being emitted, as reported in remotestorage/remotestorage-widget#69.

I added two test cases for both the ProgressEvent and the timeout case. I also fixed all the linting errors for the dropbox-suite.js test file. For that I had to change the indentation, so the diff shown in here is for the whole file. But that's a different commit, the commit with the fix just contains the actual tests added.

@galfert galfert referenced this pull request Nov 24, 2017

Closed

Prevent app sync error #69

@skddc

This comment has been minimized.

Copy link
Member

skddc commented Nov 24, 2017

Very cool! Code lgtm and verified the fix with the widget demo.

@skddc skddc merged commit bfc8fe3 into master Nov 24, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@skddc skddc deleted the bugfix/69-fix_offline_app_sync_error branch Nov 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment