Skip to content

iam:GetUser is not required#1544

Merged
JonnyBurger merged 3 commits into
remotion-dev:mainfrom
alexey-pelykh:feature/no-GetUser
Dec 7, 2022
Merged

iam:GetUser is not required#1544
JonnyBurger merged 3 commits into
remotion-dev:mainfrom
alexey-pelykh:feature/no-GetUser

Conversation

@alexey-pelykh
Copy link
Copy Markdown
Contributor

@alexey-pelykh alexey-pelykh commented Dec 6, 2022

It's possible to use an equivalent of aws sts get-caller-identity to achieve the same goals.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Dec 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
remotion ✅ Ready (Inspect) Visit Preview Dec 7, 2022 at 4:44PM (UTC)

@alexey-pelykh
Copy link
Copy Markdown
Contributor Author

@JonnyBurger would it be possible to share why Vercel is complaining? The logs are not public it seems

@JonnyBurger
Copy link
Copy Markdown
Member

Thanks a lot for this PR! 🙌

I think it was some weird lockfile conflict, let's try again! Will review this soon, need to first understand what exactly is going with STS! I'm still unfamiliar with it

@alexey-pelykh
Copy link
Copy Markdown
Contributor Author

Thanks for the insight into why it failed! I took the liberty to squash the commits for easier management

@JonnyBurger
Copy link
Copy Markdown
Member

🔥 Super awesome! I did not know that, less permissions is always better! Thanks a lot for sending this!

@JonnyBurger JonnyBurger enabled auto-merge December 7, 2022 16:35
@JonnyBurger JonnyBurger merged commit 8860d76 into remotion-dev:main Dec 7, 2022
@alexey-pelykh alexey-pelykh deleted the feature/no-GetUser branch December 7, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants