Skip to content

Drop S3 Website option#1554

Merged
JonnyBurger merged 2 commits into
remotion-dev:mainfrom
alexey-pelykh:feature/no-s3-static-website
Dec 9, 2022
Merged

Drop S3 Website option#1554
JonnyBurger merged 2 commits into
remotion-dev:mainfrom
alexey-pelykh:feature/no-s3-static-website

Conversation

@alexey-pelykh

Copy link
Copy Markdown
Contributor

The S3 Website option is not needed and is not really used since the default S3 endpoint (not the S3 Website endpoint) is being used everywhere. Also, the S3 Website endpoint does not support HTTPS protocol which is now required for the proxy to work on lambda due to the Private Network Access.

@vercel

vercel Bot commented Dec 9, 2022

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
remotion ✅ Ready (Inspect) Visit Preview Dec 9, 2022 at 0:56AM (UTC)

@JonnyBurger

Copy link
Copy Markdown
Member

Thanks a lot! This is very embarassing, I simply was not aware that we are not using the S3 website.
We also never printed the right endpoint, so I think we are safe in just removing this feature.

I also had no idea that the website feature was this cursed that endpoint is sometimes with a - and a .. And that it supports only HTTP 😅 which I think was the curlprit in the end.

@JonnyBurger JonnyBurger enabled auto-merge December 9, 2022 12:58
@JonnyBurger JonnyBurger merged commit 1c1b9ca into remotion-dev:main Dec 9, 2022
@alexey-pelykh alexey-pelykh deleted the feature/no-s3-static-website branch December 9, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants