Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop S3 Website option #1554

Merged

Conversation

alexey-pelykh
Copy link
Contributor

The S3 Website option is not needed and is not really used since the default S3 endpoint (not the S3 Website endpoint) is being used everywhere. Also, the S3 Website endpoint does not support HTTPS protocol which is now required for the proxy to work on lambda due to the Private Network Access.

@vercel
Copy link

vercel bot commented Dec 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
remotion ✅ Ready (Inspect) Visit Preview Dec 9, 2022 at 0:56AM (UTC)

@JonnyBurger
Copy link
Member

Thanks a lot! This is very embarassing, I simply was not aware that we are not using the S3 website.
We also never printed the right endpoint, so I think we are safe in just removing this feature.

I also had no idea that the website feature was this cursed that endpoint is sometimes with a - and a .. And that it supports only HTTP 😅 which I think was the curlprit in the end.

@JonnyBurger JonnyBurger merged commit 1c1b9ca into remotion-dev:main Dec 9, 2022
@alexey-pelykh alexey-pelykh deleted the feature/no-s3-static-website branch December 9, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants