Skip to content

[#344] customize error ui#654

Merged
JonnyBurger merged 6 commits intoremotion-dev:mainfrom
AudreyKj:fix/344-customize-error-ui-of-player
Oct 25, 2021
Merged

[#344] customize error ui#654
JonnyBurger merged 6 commits intoremotion-dev:mainfrom
AudreyKj:fix/344-customize-error-ui-of-player

Conversation

@AudreyKj
Copy link
Contributor

@AudreyKj AudreyKj commented Oct 18, 2021

closes #344

  • error message shown in the Error Boundary is customizable (the default is set to '⚠️')
  • updated the test validate-prop

@JonnyBurger JonnyBurger enabled auto-merge October 25, 2021 20:40
Copy link
Member

@JonnyBurger JonnyBurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this contribution, and sorry again for taking some time to review it! 🙌 💙

I'll release this tomorrow.

@JonnyBurger JonnyBurger merged commit bf2bd7a into remotion-dev:main Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Customize error UI of <Player/>

2 participants