Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Support relative <img src=> URLs. #36

Merged
merged 1 commit into from Jan 3, 2014

Conversation

Projects
None yet
2 participants
Contributor

jorendorff commented Nov 22, 2013

img.src is an absolute URL. jsdom's img.src getter produces this URL by resolving the <img src=> attribute value relative to the document's URL—which is bogus unless we explicitly pass a correct URL to jsdom.env() to start with.

(With this change, inliner works on http://people.mozilla.org/~jorendorff/es6-draft.html.)

@jorendorff jorendorff Support relative <img src=> URLs.
img.src is an absolute URL. jsdom's img.src getter produces this URL by
resolving the <img src=> attribute value relative to the document's URL --
which is bogus unless we explicitly pass a correct URL to jsdom.env() to
start with.
4e5d0b6

@remy remy added a commit that referenced this pull request Jan 3, 2014

@remy remy Merge pull request #36 from jorendorff/master
Support relative <img src=> URLs.
574f2c3

@remy remy merged commit 574f2c3 into remy:master Jan 3, 2014

1 check failed

default The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment