Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect env.OPENCOLLECTIVE_HIDE #1765

Merged
merged 1 commit into from Sep 17, 2020

Conversation

@woodcockjosh
Copy link
Contributor

@woodcockjosh woodcockjosh commented Sep 17, 2020

Respect official environment variable to hide codecollective notifications OPENCOLLECTIVE_HIDE

@remy remy merged commit 273d774 into remy:master Sep 17, 2020
8 checks passed
8 checks passed
@netlify
Header rules No header rules processed
Details
@netlify
Pages changed All files already uploaded
Details
@netlify
Redirect rules No redirect rules processed
Details
@netlify
Mixed content No mixed content detected
Details
@remy
ci/semantic-release expected next release: 2.0.5
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@netlify
deploy/netlify Deploy preview ready!
Details
security/snyk (remy) No manifest changes detected in 1 project
Details
@XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Nov 24, 2020

@remy have you thought about hiding the postinstall message on CI, if process.env.CI is truthy?

@remy
Copy link
Owner

@remy remy commented Nov 24, 2020

@XhmikosR happy to add that - but you really shouldn't be installing nodemon in your CI env! (ie. only prod deps)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants