Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: package.main with -- arguments #1773

Merged
merged 3 commits into from Oct 4, 2020
Merged

fix: package.main with -- arguments #1773

merged 3 commits into from Oct 4, 2020

Conversation

@remy
Copy link
Owner

@remy remy commented Oct 4, 2020

Fixes #1758

The combination of using a package.main (which sets the script position to index zero) and using the -- stop slurp meant that the arguments had the script appended to the end instead of prepended to the start. The net result meant that when the script was forked, it would drop the first user arg.

See diff for details of the fix - a simple check against null.

remy added 3 commits Oct 4, 2020
Fixes #1758

The combination of using a package.main (which sets the script
position to index zero) and using the -- stop slurp meant that
the arguments had the script appended to the end instead of
prepended to the start. The net result meant that when the script
was forked, it would drop the first user arg.

See diff for details of the fix - a simple check against null.
@remy remy merged commit 2967726 into master Oct 4, 2020
9 checks passed
9 checks passed
@netlify
Header rules No header rules processed
Details
@netlify
Pages changed All files already uploaded
Details
@netlify
Redirect rules No redirect rules processed
Details
@netlify
Mixed content No mixed content detected
Details
@remy
ci/semantic-release expected next release: 2.0.5
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@netlify
deploy/netlify Deploy preview ready!
Details
security/snyk (remy) No manifest changes detected in 1 project
Details
@remy remy deleted the fix/1758 branch Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant