Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve unknown user agent on fetch request #11

Merged
merged 1 commit into from Oct 5, 2019

Conversation

@justinribeiro
Copy link
Contributor

justinribeiro commented Oct 4, 2019

For your consideration: while recently testing webmention.app and my blog-pwa experiment, I noticed that the initial request doesn't set a User-Agent string when fetching for parsing:

image

While the spec doesn't really say what a parser request should send, the sender part of the spec says it should have a UA of 'webmention', so I cloned your existing UA from the send portion and patched the fetch to match:

image

"fix" is probably a strong word; it's more of a tiny patch. :-)

@now

This comment has been minimized.

Copy link

now bot commented Oct 4, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://wm-git-fork-justinribeiro-add-request-user-agent.rem.now.sh

@now now bot temporarily deployed to staging Oct 5, 2019 Inactive
@remy remy merged commit ed83393 into remy:master Oct 5, 2019
1 check passed
1 check passed
now Deployment has completed
Details
@remy

This comment has been minimized.

Copy link
Owner

remy commented Oct 5, 2019

Sweet, thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.