Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launcher become unresponsive when trying to copy a large save directory #1

Closed
remyroy opened this issue Dec 31, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@remyroy
Copy link
Owner

commented Dec 31, 2015

When your save directory becomes large, the update process can take a while to complete when it tries to copy your save folder from your previous version to the new one on slow hard drives. The UI will become unresponsive because of this.

There is no workaround for this. Waiting for the launcher to become responsive again is the best way to solve this. Forcing the application to close will potentially make the save folder corrupted. The save folder of your previous version should still be fine.

Possible solutions are to include an option not to move or copy the save folder, use NTFS junctions to share the save folder between the previous version and the new one or add a better progress bar to see the progress of copying those files instead of making the UI unresponsive.

@remyroy

This comment has been minimized.

Copy link
Owner Author

commented Jan 1, 2016

v0.3 includes a setting that will prevent copying or moving the save directory as a good workaround for this.

@DanmakuDan

This comment has been minimized.

Copy link

commented Jan 1, 2016

Does python have asynchronous IO, or threads that could avoid the freezing?

@remyroy

This comment has been minimized.

Copy link
Owner Author

commented Jan 1, 2016

It does but that is not the problem. The progress needs to be communicated to the user which is just a bit more complicated. It will eventually be added.

@remyroy

This comment has been minimized.

Copy link
Owner Author

commented Jan 8, 2016

The last few commits include a good amount of features to help with this problem. Saves information is now displayed in the game group box. A warning is now displayed if the size of the save directory is larger than 150 MiB. There is a new progressive display for the copy step of the save directory showing more information and preventing the UI from becoming unresponsive.

Someone who has a large save directory and do not want to use the Do not copy or move the save directory option will be able to see the progress on the copying of the save directory and wait for it to complete.

@remyroy remyroy closed this Jan 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.