New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fresh install of CDDA will not launch ("Save directory not found") if "Backup saves before game launch" option is turned on #205

Closed
cake-pie opened this Issue Aug 14, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@cake-pie

cake-pie commented Aug 14, 2018

Per title, a minor GUI/QoL issue.

Encountered this while using the launcher to make a fresh install for dev purposes, separate from the one I play on. This issue may affect first time users as well.

Steps to reproduce:

  1. Run launcher
  2. In "Backups" tab, enable automatic backup of saves before game launch
  3. In "Game" section under "Main" tab, specify an empty directory for a fresh install
  4. Use launcher to install a fresh copy of CDDA into the specified directory
  5. Check filesystem, note that the fresh install does not have a "save" folder; this is also reflected by "Saves: Unknown" in "Game" section under "Main" tab.
  6. Attempt to launch the game. Note "Save directory not found" error in status bar:
    launch-fresh-install

The error message is not conspicuous, so it takes a while before user notices that the game hasn't been launched.

Workaround:

Temporarily turn off automatic backup so that game will be launched.

Suggestion:

Use a popup to alert the user + provide a choice:

Save directory not found, unable to automatically backup saves before game launch.
This is normal if you have just installed the game and are running it for the first time.
Continue launching game without backing up? (Y/N)

This provides

  • clear and immediate notification / information to the user
  • seamless way to proceed if nothing is amiss
  • abort mechanism if something has gone wrong -- saves have somehow gone missing -- vs. silently continuing to launch the game
@remyroy

This comment has been minimized.

Owner

remyroy commented Aug 15, 2018

That's the kind of bug report I like!

Thanks for this report. I'll see what I can do.

@remyroy

This comment has been minimized.

Owner

remyroy commented Oct 2, 2018

This should be fixed with 2eb23cd and should be part of the next release. Thanks again.

@remyroy remyroy closed this Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment