Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Point the launcher at the new build system #557

Closed
Inglonias opened this issue May 8, 2021 · 13 comments
Closed

Point the launcher at the new build system #557

Inglonias opened this issue May 8, 2021 · 13 comments

Comments

@Inglonias
Copy link

Is your feature request related to a problem? Please describe.
With the Jenkins build bot being migrated away from in favor of Github actions, the launcher can no longer be used to update the game.

Describe the solution you'd like
Point the launcher at the new build system.

Describe alternatives you've considered
I dunno. I could learn enough python to do it myself, I guess? That may take a while, and it sounds like a lot of work.

Additional context
Add any other context or screenshots about the feature request here.

@kevingranade
Copy link

kevingranade commented May 10, 2021

We might just have the new build process emit the same data that the Jenkins build did previously, at which point the launcher will just go back to working. I don't recall offhand what all it fetches or if it tries to fetch anything directly from narc.ro, so it'll take a little digging.
EDIT:
I see it's pulling from narc.ro here

request = QNetworkRequest(QUrl(cons.CHANGELOG_URL))

So that will definitely need to be changed to get it working again.

@remyroy
Copy link
Owner

remyroy commented May 12, 2021

The launcher should be able to get the new builds with this recents change: f57b318 . It will be part of the next release. I'm currently improving the executable bundle process so it will be less likely to trigger AV products. This might take a little while.

@kevingranade
Copy link

To be clear, it should be pretty straightforward to get the new build artifacts from the github release API, but the more iffy thing is the changelog since that was being served by narc.ro and we don't have a 1:1 replacement for that.

@Inglonias
Copy link
Author

Doesn't the build action occur every time there's a commit? Use the commit message as the changelog.

@remyroy
Copy link
Owner

remyroy commented May 13, 2021

The changelog has been removed when selecting the experimental branch until there is a replacement.

@kevingranade
Copy link

No, it is triggered on merge, which can be an arbitrary number of commits, and we just pushed a change that prevents overlapping releases, so there will be multiple merges per release if they're fast enough. What I'm thinking is the list of commit messages can either be retrieved from the github API or maybe we can write it to the description of the release.

@kevingranade
Copy link

It looks like the commit span doesn't make it into the release by default, so we need to capture something during the release process and write it to the release.

@ZhilkinSerg
Copy link
Contributor

@remyroy

New experimental release tag naming scheme:

New experimental release artifact naming scheme:

@remyroy
Copy link
Owner

remyroy commented May 14, 2021

I guess we'll need another update 😄

@remyroy
Copy link
Owner

remyroy commented May 14, 2021

@ZhilkinSerg

The new tag will break our ability to search by build number if it includes the date.

We can easily search for build #33 if it uses the experimental-33 tag like on this release: https://github.com/CleverRaven/Cataclysm-DDA/releases/tag/experimental-33

but we cannot search for build #1641 if it uses the cdda-experimental-2021-05-14-1641 tag (with the date in it) like on this release: https://github.com/CleverRaven/Cataclysm-DDA/releases/tag/cdda-experimental-2021-05-14-1641

We can adjust for the date being in the asset name without any issue. Just that the tag naming will cause some issues.

@remyroy
Copy link
Owner

remyroy commented May 14, 2021

Or maybe we could use the full date and number at the end as the build number.

@remyroy
Copy link
Owner

remyroy commented May 14, 2021

This should be taken care of in 546fe9b

@ZhilkinSerg
Copy link
Contributor

You can allow entering hyphens in addition to numbers to "Find build #" field (or use mask).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants