New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mod links #162

Merged
merged 20 commits into from May 10, 2018

Conversation

Projects
None yet
3 participants
@ZhilkinSerg
Contributor

ZhilkinSerg commented May 6, 2018

What was changed:

@remyroy

This comment has been minimized.

Owner

remyroy commented May 8, 2018

Thanks for your work. I'll review these changes shortly.

You should avoid modifying the version number in a pull request. It will be done just before a release.

@ZhilkinSerg

This comment has been minimized.

Contributor

ZhilkinSerg commented May 8, 2018

You should avoid modifying the version number in a pull request. It will be done just before a release.

Yes, version change should not be here. That was a local test commit.

@remyroy

This comment has been minimized.

Owner

remyroy commented May 8, 2018

The dda-lua-* mods all have the same url. Is this a mistake or is this correct? If they all have the same download url, they should just be a single entry in the repository.

@remyroy

This comment has been minimized.

Owner

remyroy commented May 8, 2018

Whaleys Small Town Building Pack's download url doesn't work anymore. The entry should probably be removed until the author or someone fixes this.

@remyroy

This comment has been minimized.

Owner

remyroy commented May 8, 2018

I think the download URL for Whaleys Small Town Building Packs should be
https://www.dropbox.com/s/1rtpemg9pxbt0lb/Small%20Town%20Building%20Pack.zip?dl=1 and the type changed to direct_download since the launcher can download from dropbox directly (when you add the ?dl=1 at the end)

@ZhilkinSerg

This comment has been minimized.

Contributor

ZhilkinSerg commented May 8, 2018

I think the download URL for Whaleys Small Town Building Packs should be
https://www.dropbox.com/s/1rtpemg9pxbt0lb/Small%20Town%20Building%20Pack.zip?dl=1

Yes, thanks.

The dda-lua-* mods all have the same url. Is this a mistake or is this correct? If they all have the same download url, they should just be a single entry in the repository.

dda-lua-* is collection of multiple mods which come in same archive (https://github.com/ZhilkinSerg/Cataclysm-DDA-LUA/archive/master.zip). It would be good if launcher supported downloading and caching of single archive and unpacking multiple mods from this archive.

@remyroy

This comment has been minimized.

Owner

remyroy commented May 8, 2018

I can implement installing multiple distinct mods from a single archive. This will require a new format for the mods.json repository data as I check for existing mods with the same ident value and I expect a single value with the ident property in that JSON file.

So instead of many entries with "ident": "something", you should have a single entry with:

"ident": ["dda-lua", "dda-lua-fun", "dda-lua-items", "dda-lua-skills", "dda-lua-traits"]

@remyroy

This comment has been minimized.

Owner

remyroy commented May 10, 2018

Implementation for installing archives containing multiple mods has been added with b9da9ce and 6518d71. If you want to include your mods with a single entry in mods.json like I mentionned, I'll merge this pull request.

@ZhilkinSerg

This comment has been minimized.

Contributor

ZhilkinSerg commented May 10, 2018

Implementation for installing archives containing multiple mods has been added with b9da9ce and 6518d71. If you want to include your mods with a single entry in mods.json like I mentionned, I'll merge this pull request.

Thanks. Done.

@remyroy remyroy merged commit bd34a75 into remyroy:master May 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment