Repository navigation
Set benchmark-specific thread limits for the Spark local executor - #284
Merged
Merged
Conversation
The limits reflect the recommendations in #260 (comment)
Member
|
Related to #283: perhaps there should be some hard minimum too? |
Member
Author
|
Spark should be fine even with 1 CPU. On my machine (32G RAM, 4*2 CPUs), Spark benchmarks run (albeit slowly) under |
Member
Author
|
If the thread limits are fine, I'd suggest merging this, because the issue with #283 appears to be related to thread stack size. If we end up imposing a minimal number of threads to work around the thread stack size, it would be better to do it in another PR anyway. |
farquet
approved these changes
Jul 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The limits reflect the recommendations from #260, with the limits for
gauss-mix,chi-squareanddec-treebumped up by 2 threads (providing a bit of slack that does not help but should not hurt), resulting in the following defaults for thespark_thread_limitparameter:chi-squareandgauss-mixdec-treemovie-lensals,als-ml,log-regressionandpage-ranknaive-bayes