Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and commonize some of the dependencies #342

Merged
merged 16 commits into from
Dec 20, 2021

Conversation

lbulej
Copy link
Member

@lbulej lbulej commented Dec 20, 2021

Updates and commonizes versions for some of the benchmark dependencies.

For primary dependencies that are typically unique to a benchmark module, the updated versions affects just the benchmarks in the module and if we use a newer version, some of their transitive dependencies may use a newer versions and can be shared with other modules. For example, updating the finagle artifacts leads to newer zstd-jni, which can be implicitly shared with apache-spark.

For secondary/transitive dependencies, the forced update applies to several benchmarks, but these are mostly support libraries. For example, we shipped 4 different versions of various netty artifacts, but now we ship just one, which should avoid issues such as #337.

  • actors-akka benchmarks
    • akka-actor, 2.6.12 -> 2.6.17
  • apache-spark benchmarks
    • guava, 16.0.1 -> 23.0
    • commons-compress, 1.20 -> 1.21
    • commons-io, 2.8.0 -> 2.11.0
    • commons-logging, 1.1.3 -> 1.2
    • commons-math3, 3.4.1 -> 3.6.1
    • commons-text, 1.6 -> 1.9
    • netty-all, 4.1.68.Final -> 4.1.72.Final
      • netty-buffer, netty-codec, netty-common, netty-handler, netty-resolver, netty-transport-*, 4.1.50.Final -> 4.1.72.Final
      • the individual artifacts (with different version) were pulled in by zookeeper
    • scala-collections-compat_2.13, 2.2.0 -> 2.6.0
    • scala-parallel-collections_2.13, 1.0.3 -> 1.0.4
    • slf4j-api, slf4j-log4j12, jcl-over-slf4j, jul-to-slf4j, 1.7.30 -> 1.7.32
    • zookeeper, 3.6.2 -> 3.6.3
  • database benchmarks
    • guava, 19.0 -> 23.0
    • jcl-over-slf4j, 1.6.6 -> 1.7.32
    • jna, 4.2.1 -> 5.10.0
    • slf4j-api, slf4j-simple, 1.7.25 -> 1.7.32
    • there are many other primary dependencies that could be updated, but this needs to be handled slowly, because historically this benchmark has been a bit fragile
  • jdk-concurrent benchmarks
    • jenetics, 4.4.0 -> 5.2.0
      • version 6.0.0 is available, but would require benchmark update
  • neo4j benchmarks
    • jna, 5.6.0 -> 5.10.0
    • lift-json, 3.4.3 -> 3.5.0
    • neo4j, 4.2.4 -> 4.4.0
      • still does not support Scala 2.13
    • netty-all, 4.1.55.Final -> 4.1.72.Final
    • slf4j-api, slf4j-nop, 1.7.30 -> 1.7.32
  • renaissance-harness module
    • scala-collections-compat_2.13, uses 2.6.0
  • rx benchmarks
    • rxjava, 1.3.7 -> 1.3.8
  • scala-dotty benchmarks
    • scala3-compiler_3, 3.0.0 -> 3.0.2
      • updated expectedTastyHash in Dotty.scala
    • jna, 5.3.1 -> 5.10.0
  • twitter-finagle benchmarks
    • finagle-core, finagle-http, finagle-stats, util-core, 21.10.0 -> 21.11.0
    • guava, 19.0 -> 23.0
    • netty-all, 4.1.66.Final -> 4.1.72.Final
    • scala-collections-compat_2.13, 2.4.4 -> 2.6.0
    • scala-parallel-collections_2.13, uses 1.0.4
    • slf4j-simple, keep 1.7.32

Things have been working on my machine, but it would help if somebody else could give it a try.

@farquet farquet self-requested a review December 20, 2021 14:54
@lbulej lbulej merged commit be1e64f into master Dec 20, 2021
@lbulej lbulej deleted the topic/update-commonize-dependencies branch December 20, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants