Update and commonize some of the dependencies #342
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates and commonizes versions for some of the benchmark dependencies.
For primary dependencies that are typically unique to a benchmark module, the updated versions affects just the benchmarks in the module and if we use a newer version, some of their transitive dependencies may use a newer versions and can be shared with other modules. For example, updating the
finagleartifacts leads to newerzstd-jni, which can be implicitly shared withapache-spark.For secondary/transitive dependencies, the forced update applies to several benchmarks, but these are mostly support libraries. For example, we shipped 4 different versions of various
nettyartifacts, but now we ship just one, which should avoid issues such as #337.actors-akkabenchmarksakka-actor, 2.6.12 -> 2.6.17apache-sparkbenchmarksguava, 16.0.1 -> 23.0commons-compress, 1.20 -> 1.21commons-io, 2.8.0 -> 2.11.0commons-logging, 1.1.3 -> 1.2commons-math3, 3.4.1 -> 3.6.1commons-text, 1.6 -> 1.9netty-all, 4.1.68.Final -> 4.1.72.Finalnetty-buffer,netty-codec,netty-common,netty-handler,netty-resolver,netty-transport-*, 4.1.50.Final -> 4.1.72.Finalzookeeperscala-collections-compat_2.13, 2.2.0 -> 2.6.0scala-parallel-collections_2.13, 1.0.3 -> 1.0.4slf4j-api,slf4j-log4j12,jcl-over-slf4j,jul-to-slf4j, 1.7.30 -> 1.7.32zookeeper, 3.6.2 -> 3.6.3databasebenchmarksguava, 19.0 -> 23.0jcl-over-slf4j, 1.6.6 -> 1.7.32jna, 4.2.1 -> 5.10.0slf4j-api,slf4j-simple, 1.7.25 -> 1.7.32jdk-concurrentbenchmarksjenetics, 4.4.0 -> 5.2.0neo4jbenchmarksjna, 5.6.0 -> 5.10.0lift-json, 3.4.3 -> 3.5.0neo4j, 4.2.4 -> 4.4.0netty-all, 4.1.55.Final -> 4.1.72.Finalslf4j-api,slf4j-nop, 1.7.30 -> 1.7.32renaissance-harnessmodulescala-collections-compat_2.13, uses 2.6.0rxbenchmarksrxjava, 1.3.7 -> 1.3.8scala-dottybenchmarksscala3-compiler_3, 3.0.0 -> 3.0.2expectedTastyHashinDotty.scalajna, 5.3.1 -> 5.10.0twitter-finaglebenchmarksfinagle-core,finagle-http,finagle-stats,util-core, 21.10.0 -> 21.11.0guava, 19.0 -> 23.0netty-all, 4.1.66.Final -> 4.1.72.Finalscala-collections-compat_2.13, 2.4.4 -> 2.6.0scala-parallel-collections_2.13, uses 1.0.4slf4j-simple, keep 1.7.32Things have been working on my machine, but it would help if somebody else could give it a try.