Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preventDefault() in toggle code interferes with other UI functionality #109

Closed
vanboom opened this issue Mar 31, 2020 · 2 comments
Closed

Comments

@vanboom
Copy link

vanboom commented Mar 31, 2020

I have a tabbed interface where I would like to kick off the render async when the user selects a tab. The tab system is built using a radio and HTML/CSS only.

I can attach render_async toggle selector to the ID of the radio button that controls the tab switching, but preventDefault() is keeping the default radio behavior from happening.

I am proposing that the preventDefault() be removed from _request_jquery.js.erb:105. So far in my app I have not found any negative ramifications of doing so.

Thanks for all you guys do on this gem.

@nikolalsvk
Copy link
Collaborator

nikolalsvk commented May 9, 2020

Closed in #110

@nikolalsvk
Copy link
Collaborator

nikolalsvk commented May 9, 2020

This is resolved in 2.1.6. Let's reopen it in case it's not!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants