From 51a6ece3338717900cf52676775f446253aa16d8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20S=CC=8Cinku=CC=84nas?= Date: Tue, 7 Jun 2022 17:24:36 +0300 Subject: [PATCH 1/9] create main.yml file --- .github/workflows/main.yml | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 .github/workflows/main.yml diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml new file mode 100644 index 0000000..30250f8 --- /dev/null +++ b/.github/workflows/main.yml @@ -0,0 +1,28 @@ +name: Install, lint and package +on: + # Triggers the workflow on push or pull-request events for the main and dev branches + push: + branches: [main, dev] + pull_request: + branches: [main, dev] + +jobs: + install-lint-package: + runs-on: ubuntu-latest + steps: + - name: Checkout Git repository + - uses: actions/checkout@v3 + + - name: Install node + uses: actions/setup-node@v3 + with: + node-version: 14 + + - name: Install dependencies + run: npm ci + + - name: Lint codebase + run: npm run lint + + - name: Create package + run: npm run package From e1ab5cff2dee411a4385a2a825ff7d000cbec2ff Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20S=CC=8Cinku=CC=84nas?= Date: Tue, 7 Jun 2022 17:27:13 +0300 Subject: [PATCH 2/9] rename branches --- .github/workflows/main.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 30250f8..49f0bd9 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -1,10 +1,10 @@ name: Install, lint and package on: - # Triggers the workflow on push or pull-request events for the main and dev branches + # Triggers the workflow on push or pull-request events for the master and Dev branches push: - branches: [main, dev] + branches: [master, Dev] pull_request: - branches: [main, dev] + branches: [master, Dev] jobs: install-lint-package: From ca24e5ce50c13d99b293e68c3ede087dd966a465 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20S=CC=8Cinku=CC=84nas?= Date: Tue, 7 Jun 2022 17:30:47 +0300 Subject: [PATCH 3/9] add dashes --- .github/workflows/main.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 49f0bd9..14860ec 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -14,15 +14,15 @@ jobs: - uses: actions/checkout@v3 - name: Install node - uses: actions/setup-node@v3 + - uses: actions/setup-node@v3 with: node-version: 14 - name: Install dependencies - run: npm ci + - run: npm ci - name: Lint codebase - run: npm run lint + - run: npm run lint - name: Create package - run: npm run package + - run: npm run package From faed99d3bc6030debcbb8fe3a7a6744be5de8e70 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20S=CC=8Cinku=CC=84nas?= Date: Tue, 7 Jun 2022 17:35:06 +0300 Subject: [PATCH 4/9] remove dashes --- .github/workflows/main.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 14860ec..1ea4134 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -11,18 +11,18 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout Git repository - - uses: actions/checkout@v3 + uses: actions/checkout@v3 - name: Install node - - uses: actions/setup-node@v3 + uses: actions/setup-node@v3 with: node-version: 14 - name: Install dependencies - - run: npm ci + run: npm ci - name: Lint codebase - - run: npm run lint + run: npm run lint - name: Create package - - run: npm run package + run: npm run package From c49c039ae50c0edf7eeacee11e051fb18750f354 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20S=CC=8Cinku=CC=84nas?= Date: Tue, 7 Jun 2022 17:37:33 +0300 Subject: [PATCH 5/9] make a test eith a warning --- lib/extension.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/extension.js b/lib/extension.js index c728130..489b444 100644 --- a/lib/extension.js +++ b/lib/extension.js @@ -12,6 +12,9 @@ function activate() { buildCommand(hostApp) ); }); + + return; + var a = 10; } exports.activate = activate; From ea394e0f21cd76ebd825d8c593eb3e3a20f2cab0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20S=CC=8Cinku=CC=84nas?= Date: Tue, 7 Jun 2022 17:41:38 +0300 Subject: [PATCH 6/9] make a failing test --- .eslintrc.json | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.eslintrc.json b/.eslintrc.json index 214df72..57ba6da 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -11,11 +11,5 @@ "jsx": true }, "sourceType": "module" - }, - "rules": { - "no-unreachable": "warn", - "no-unused-vars": "warn", - "semi": "warn", - "valid-typeof": "warn" } } From af49ed824a177e35b4a8ffee52fc9a6143eb283e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20S=CC=8Cinku=CC=84nas?= Date: Tue, 7 Jun 2022 17:46:51 +0300 Subject: [PATCH 7/9] revert --- lib/extension.js | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/extension.js b/lib/extension.js index 489b444..c728130 100644 --- a/lib/extension.js +++ b/lib/extension.js @@ -12,9 +12,6 @@ function activate() { buildCommand(hostApp) ); }); - - return; - var a = 10; } exports.activate = activate; From 3d15a57b869746db4452fb35f15532b5869e82da Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20S=CC=8Cinku=CC=84nas?= Date: Tue, 7 Jun 2022 17:47:02 +0300 Subject: [PATCH 8/9] setup vscode settings --- .vscode/settings.json | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.vscode/settings.json b/.vscode/settings.json index 92d4065..93af001 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -1,4 +1,11 @@ // Place your settings in this file to overwrite default and user settings. { + "[javascript]": { + "editor.defaultFormatter": "esbenp.prettier-vscode", + "editor.codeActionsOnSave": { + "source.fixAll.eslint": true + }, + "editor.formatOnSave": true + }, "terminal.integrated.shell.windows": "C:\\Windows\\System32\\cmd.exe" } From ac9496273fc2ca96c91f99726422e59349233bed Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20S=CC=8Cinku=CC=84nas?= Date: Tue, 7 Jun 2022 18:05:29 +0300 Subject: [PATCH 9/9] update eslint --- .eslintrc.json | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/.eslintrc.json b/.eslintrc.json index 57ba6da..70300b7 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -6,10 +6,8 @@ "node": true }, "extends": ["eslint:recommended", "plugin:prettier/recommended"], - "parserOptions": { - "ecmaFeatures": { - "jsx": true - }, - "sourceType": "module" + "plugins": ["prettier"], + "rules": { + "prettier/prettier": "error" } }