Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upSet 'selected' attr via Mojo controller #4
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
paultcochrane commentedApr 10, 2018
•
edited
... instead of setting the 'selected' attribute directly. The reason
for this commit is because how the 'selected' attribute was handled was
changed in Mojolicious version 6.16 (see the release
changes
for more info) and the tests for this plugin had begun failing as of
this Mojo version. The behaviour of the 'selected' attribute was also
changed in Mojolicious version 5.73 (it's necessary to diff the 5.73 <->
5.72 versions in order to see this; it's not mentioned in the Changes)
which meant that setting the
selectedattribute to a true value nolonger uses
selected='selected'but simply the presence of theselectedattribute is sufficient to set it to a true value. Thiscommit should fix the current failures occurring on CPAN Testers and should fix issue #3.
If you have any questions or comments concerning this PR, please don't hesitate to contact me. Also, if you want anything changed, just let me know and I can update and resubmit as required.