New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set 'selected' attr via Mojo controller #4

Merged
merged 1 commit into from Apr 10, 2018

Conversation

Projects
None yet
2 participants
@paultcochrane
Contributor

paultcochrane commented Apr 10, 2018

... instead of setting the 'selected' attribute directly. The reason
for this commit is because how the 'selected' attribute was handled was
changed in Mojolicious version 6.16 (see the release
changes

for more info) and the tests for this plugin had begun failing as of
this Mojo version. The behaviour of the 'selected' attribute was also
changed in Mojolicious version 5.73 (it's necessary to diff the 5.73 <->
5.72 versions in order to see this; it's not mentioned in the Changes)
which meant that setting the selected attribute to a true value no
longer uses selected='selected' but simply the presence of the
selected attribute is sufficient to set it to a true value. This
commit should fix the current failures occurring on CPAN Testers and should fix issue #3.

If you have any questions or comments concerning this PR, please don't hesitate to contact me. Also, if you want anything changed, just let me know and I can update and resubmit as required.

Set 'selected' attr via Mojo controller
... instead of setting the 'selected' attribute directly.  The reason
for this commit is because how the 'selected' attribute was handled was
changed in Mojolicious version 6.16 (see [the release
changes](https://metacpan.org/changes/release/SRI/Mojolicious-7.74#L784)
for more info) and the tests for this plugin had begun failing as of
this Mojo version.  The behaviour of the 'selected' attribute was also
changed in Mojolicious version 5.73 (it's necessary to diff the 5.73 <->
5.72 versions in order to see this; it's not mentioned in the Changes)
which meant that setting the `selected` attribute to a true value no
longer uses `selected='selected'` but simply the presence of the
`selected` attribute is sufficient to set it to a true value.  This
commit should fix the current failures occurring on CPAN Testers.

@reneeb reneeb merged commit cf5a355 into reneeb:master Apr 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment