New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure tests run in series #6

Merged
merged 1 commit into from Apr 21, 2017

Conversation

Projects
None yet
2 participants
@mjg17
Contributor

mjg17 commented Apr 21, 2017

Hi, I'm submitting this pull request because Test::CheckManifest was allocated to me as my April assignment in the CPAN Pull Request challenge.

I looked at the issues. Although I wasn't able to replicate the parallel test failure - in issue #4 - I have been able to make use of the TAP::Harness rules support (see "rulesfiles" under https://metacpan.org/pod/TAP::Harness#new ) to ensure that the tests run sequentially.

(Parallel tests won't work because files are created and deleted in the main test, which could potentially break the other tests' manifest checks.)

I've added CPAN::Meta::YAML to the test prereqs, since the rulesfiles mechanism in TAP::Harness requires this to be available.

I hope this patch is useful.

@mjg17

This comment has been minimized.

Show comment
Hide comment
@mjg17

mjg17 Apr 21, 2017

Contributor

I also suspect this will fix some of the CPAN Testers failures, fingers crossed...

Contributor

mjg17 commented Apr 21, 2017

I also suspect this will fix some of the CPAN Testers failures, fingers crossed...

@reneeb reneeb merged commit 9c8b959 into reneeb:master Apr 21, 2017

@reneeb

This comment has been minimized.

Show comment
Hide comment
@reneeb

reneeb Apr 21, 2017

Owner

Thanks for this great pull request. It seems you're right wrt #4 . I did several test runs with and without your patch. Without your patch, the tests failed, but with your patch everything was ok...

Owner

reneeb commented Apr 21, 2017

Thanks for this great pull request. It seems you're right wrt #4 . I did several test runs with and without your patch. Without your patch, the tests failed, but with your patch everything was ok...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment