New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load plugins with Module::Pluggable #4

Merged
merged 1 commit into from Feb 10, 2017

Conversation

Projects
None yet
2 participants
@yanick
Contributor

yanick commented Feb 9, 2017

simplifying the code a wee bit by switching the manual gathering of the plugins in favor of a module that do the job for us.

(done as part of the CPAN Pull Request Challenge)

@renormalist

This comment has been minimized.

Show comment
Hide comment
@renormalist

renormalist Feb 10, 2017

Owner

Thank you very much!

The reason I did it manually was to have less risk from dependency trouble as the benchmark module will be built for the Perl version to benchmark.

However, I always disliked my manual approach and your rework looks much cleaner.

I'm not fully decided to switch over, as CPANTESTERS indicate occasional trouble. I will experiment a bit with it on my different Perl versions, let's see how it works out. Yet, it doesn't hurt to merge and roll back later if it fails.

Owner

renormalist commented Feb 10, 2017

Thank you very much!

The reason I did it manually was to have less risk from dependency trouble as the benchmark module will be built for the Perl version to benchmark.

However, I always disliked my manual approach and your rework looks much cleaner.

I'm not fully decided to switch over, as CPANTESTERS indicate occasional trouble. I will experiment a bit with it on my different Perl versions, let's see how it works out. Yet, it doesn't hurt to merge and roll back later if it fails.

@renormalist renormalist merged commit 45d759d into renormalist:master Feb 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment