New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JSON::MaybeXS #4

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@labrown
Contributor

labrown commented Jun 23, 2015

Use JSON::MaybeXS instead of the buggy, action at a distance causing, "use JSON -convert_blessed_universally".

See #3.

@renormalist

This comment has been minimized.

Show comment
Hide comment
@renormalist

renormalist Jul 9, 2015

Owner

Thanks. Give me a second to think about it - is there a lazy loading "require" form for JSON::MaybeXS which avoids the compile time "use"?

Owner

renormalist commented Jul 9, 2015

Thanks. Give me a second to think about it - is there a lazy loading "require" form for JSON::MaybeXS which avoids the compile time "use"?

@labrown

This comment has been minimized.

Show comment
Hide comment
@labrown

labrown Jul 9, 2015

Contributor

I'll see if it works as a require when I get a chance.

Contributor

labrown commented Jul 9, 2015

I'll see if it works as a require when I get a chance.

require JSON instead of using eval magic
Just "require JSON" instead of using eval magic with
'-convert_blessed_universally' which is considered a
pretty bad source of "spooky action at a distance".
@labrown

This comment has been minimized.

Show comment
Hide comment
@labrown

labrown Jul 10, 2015

Contributor

Updated PR to juse require JSON instead of using eval magic with -convert_blessed_universal_mode. This passes the tests on my system and doesn't cause problems with possible spooky action at a distance.

Contributor

labrown commented Jul 10, 2015

Updated PR to juse require JSON instead of using eval magic with -convert_blessed_universal_mode. This passes the tests on my system and doesn't cause problems with possible spooky action at a distance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment